Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generating an OpenAPI spec #62

Open
brayniverse opened this issue Mar 29, 2023 · 6 comments
Open

Generating an OpenAPI spec #62

brayniverse opened this issue Mar 29, 2023 · 6 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@brayniverse
Copy link

Hello 👋,

I have been manually creating a JSON:API implementation and while I think we've been doing a good job there has been mistakes along the way. When looking at this package I reckon we wouldn't have made as many if we were using json-api-server. I have been experimenting with the package and it seems really good.

All this is to say, I'm still new to the package and forgive me if this has already been asked. As far as I could tell, there hasn't been a discussion on it yet.

Is it possible to generate an OpenAPI spec file from the schema you define as part of json-api-server? It seems like all the information to generate one is available. If it is not currently possible, would you consider including it as part of the core package if I were to help implement it?

Thank you,

Chris

@tobyzerner
Copy link
Owner

Hey Chris, thank you for the kind words 😊

You're right that this hasn't been talked about before, but it's always been in the back of my mind as something that would be possible and desirable.

In a couple months I'm starting a new job that will allow me to invest a lot more time into this package, and I'd love to look at it then. In the meantime, any start you can make would be great!

@brayniverse
Copy link
Author

@tobyzerner congratulations on the new job. I'll see what I can do.

@tobyzerner
Copy link
Owner

With the release of v1.0.0-alpha.1, which adds support for typed attributes, consider work on OpenAPI definition generation well underway :)

@tobyzerner tobyzerner added the enhancement New feature or request label Jun 21, 2023
@tobyzerner tobyzerner added this to the v1.0 milestone Jun 21, 2023
@tobyzerner tobyzerner modified the milestones: v1.0, v1.1 Jun 21, 2023
@tobyzerner tobyzerner self-assigned this Nov 7, 2023
@bertramakers
Copy link
Contributor

Hi @tobyzerner, is there any news regarding the OpenAPI spec support?

@tobyzerner
Copy link
Owner

Hi @bertramakers, work is in progress (but incomplete) on the openapi branch. Feel free to try it out and let me know what you think!

use Tobyz\JsonApiServer\OpenApi\OpenApiGenerator;

$api = new JsonApi();

// $api->resource(...) etc

$generator = new OpenApiGenerator();

print_r($generator->generate($api)); // or encode as json, yaml

@bertramakers
Copy link
Contributor

bertramakers commented Jul 24, 2024

Thanks, I'll try it out soon!

One small suggestion I already have would be to put the name of the collection in the summary of the operation instead of the tags: main...openapi#diff-03e5541a3e5fe9ec77d2c71f17861fe6c28554322af2fd5cd0f6dd5b2daa3fe7R188

See definition of summary in operation objects here: https://swagger.io/specification/#operation-object

Edit: Disregard this, it makes sense to put $collection->name() in tags because it's usually the type of the resource and not the name of the operation. It would be nice to be able to set a name/summary on the endpoint though but that's nice to have.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants