Skip to content

about international phone numbers #12

@fyears

Description

@fyears

Hi. I have some international messages, which are not exported correctly.

For example, a simple UK number should be +44 1234 123456, but your code just convert it into 1234123456, losing all the information about country code. For another example, a simple China number should be +86 123-1234-1234, and your code just convert it into 2312341234, which is even a invalid number, since even though you are allowed to omit the leading country code, the remaining leading 1 is necessary.

My suggestion is just removing strip(), trunc(), and format_phone() functions below. Or at least add a parameter like --keep-phone-number-as-is.

Original Line 129 - 158 in the code:

def strip(phone):
    #...
def trunc(phone):
    #...
def format_phone(phone):
    #...

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions