Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor/backend requester #59

Merged
merged 17 commits into from
Jan 6, 2025
Merged

Refactor/backend requester #59

merged 17 commits into from
Jan 6, 2025

Conversation

tofubert
Copy link
Owner

Closes #58
Closes #55

@tofubert tofubert self-assigned this Dec 18, 2024
@codecov Codecov
Copy link

codecov bot commented Dec 18, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 50.55612% with 489 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/backend/nc_request/nc_req_worker.rs 16.4% 219 Missing ⚠️
src/backend/nc_request/nc_requester.rs 26.9% 165 Missing ⚠️
src/ui/app.rs 0.0% 48 Missing ⚠️
src/backend/nc_talk.rs 89.4% 31 Missing ⚠️
src/backend/nc_room.rs 88.8% 10 Missing ⚠️
src/ui/chat_box.rs 38.4% 8 Missing ⚠️
src/main.rs 0.0% 3 Missing ⚠️
src/ui/chat_selector.rs 70.0% 3 Missing ⚠️
src/ui/notifications.rs 92.8% 2 Missing ⚠️
Files with missing lines Coverage Δ
src/backend/nc_request/nc_req_data_message.rs 0.0% <ø> (ø)
src/backend/nc_request/nc_req_data_room.rs 0.0% <ø> (ø)
src/config/mod.rs 93.3% <100.0%> (ø)
src/ui/title_bar.rs 93.3% <100.0%> (+0.2%) ⬆️
src/ui/users.rs 91.9% <100.0%> (ø)
src/ui/notifications.rs 46.1% <92.8%> (ø)
src/main.rs 0.0% <0.0%> (ø)
src/ui/chat_selector.rs 97.2% <70.0%> (ø)
src/ui/chat_box.rs 78.3% <38.4%> (-1.7%) ⬇️
src/backend/nc_room.rs 64.7% <88.8%> (+8.2%) ⬆️
... and 4 more

@tofubert tofubert force-pushed the refactor/backend_requester branch from 13313f8 to 578421a Compare December 21, 2024 11:10
@tofubert tofubert marked this pull request as ready for review January 6, 2025 07:39
@tofubert tofubert merged commit 054101f into main Jan 6, 2025
9 checks passed
@tofubert tofubert deleted the refactor/backend_requester branch January 6, 2025 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@tofubert tofubert

Labels
refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

nc_notify should not be in the backend but the ui
1 participant
@tofubert