Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace external tofuenv to a native Go support #8

Closed
kvendingoldo opened this issue Jan 11, 2024 · 21 comments
Closed

Replace external tofuenv to a native Go support #8

kvendingoldo opened this issue Jan 11, 2024 · 21 comments
Assignees
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@kvendingoldo
Copy link
Collaborator

kvendingoldo commented Jan 11, 2024

No description provided.

@kvendingoldo kvendingoldo changed the title Replace tofuenv to a native support Replace external tofuenv to a native Go support Jan 11, 2024
@dvaumoron
Copy link
Contributor

Hi @kvendingoldo,

Just seen you create this issue to continue our exchange started in tofuutils/tofuenv#31

@kvendingoldo
Copy link
Collaborator Author

@dvaumoron yep. Today's I gonna upload basic layout to main branch. It can help us to see how we can merge our code. I will additionally ping you when it will be done.

@kvendingoldo
Copy link
Collaborator Author

kvendingoldo commented Jan 11, 2024

@dvaumoron I've added a basic layout for tenv commands. Don't look to pkg code, it's unused for now. I appreciate your work and think that it won't be a problem to integrate it into tenv tf command. If you are ok with that, I will add you to the repo as a maintainer. Let's make this tool better together.

UPD: I've updated the code inside of main branch, now it partially support tenv tf install, tenv tofu install, tenv tf list-remote, tenv tofu list-remote command.

@kvendingoldo
Copy link
Collaborator Author

@dvaumoron wdyt?

@kvendingoldo kvendingoldo added the help wanted Extra attention is needed label Jan 12, 2024
@dvaumoron
Copy link
Contributor

I am first working on adding Terraform support to gotofuenv, the progress are fast.

After that (probably during next week), an eventual reorganization of commands will be easier.

@kvendingoldo
Copy link
Collaborator Author

@dvaumoron that sounds fantastic! Are you planning to merge your code with tenv after that? For the time being, I notice that we are doing nearly identical job, which is inefficient in my opinion.

@dvaumoron
Copy link
Contributor

The refactor with a ReleaseInfoRetriever interface will allow a better reusability of the code (if we want to keep same kind of functionnality for OpenTofu and Terraform)

I don't understand why you call it inefficiency, my work is not hidden, its location of availability doesn't change much.

@dvaumoron
Copy link
Contributor

Hi @kvendingoldo,

I released gotofuenv v1.0.0, I will slow down on it for now (only fix bugs if needed).

Before going further, I wonder, what do you envision for tenv ? What do you think should be done differently ?

@kvendingoldo
Copy link
Collaborator Author

kvendingoldo commented Jan 20, 2024

Hello @dvaumoron! I wanted to express my admiration for your incredible work.

In my previous comment, I was talking about my team's work as about smth not very useful because your code looks almost the same as we realized. Please accept my apologies for any unintended negative tone, and I genuinely commend your outstanding contribution to the migration of tofu/tf env to Golang.

We was waiting news from your side and for this reason we stopped tenv development for a while. My team still want to keep the original idea of this united tool inside of tofuutils organization and develop / promote and enhance it together in the future.

What's your thougts about the future of tool that you have written? Don't you want to migrate it to the tofuutils organisation and be a primary maintainer of it?

@dvaumoron
Copy link
Contributor

As said on Slack, I am ready to migrate, but when trying to transfer that did not work yet ("You don’t have the permission to create public repositories on tofuutils").

@kvendingoldo
Copy link
Collaborator Author

@dvaumoron can you check it now, please? I sent you an invitation.
btw. WDYT about renaming your tool to tenv? I think this name will be more suitable. We can do it after transfer.

@dvaumoron
Copy link
Contributor

I started to update after the transfer to tofuutils, I launched a release, the brew part failed.

@kvendingoldo
Copy link
Collaborator Author

@dvaumoron pls, check again. I fixed permissions

@dvaumoron
Copy link
Contributor

Everything seem to work as expected now (including the brew migration part in dvaumoron/tap, not sure there is a lot of users concerned except me, but that still better).

I followed your suggestion and renamed the managing command tenv (I tried to update display and README Accordingly, but there are still some mistake, however I will wait more important fixes before releasing again).

@kvendingoldo
Copy link
Collaborator Author

@dvaumoron I merged your repo to tenv and saved all history that you had: https://github.com/tofuutils/tenv
Don't you have any objections to use tenv for the future?

@dvaumoron
Copy link
Contributor

I have no objection, however i have some questions. Now, my work has been merge in the tenv repo, it seems appropriate to indicate in the gotofuenv readme that the work will continue there, mark it as archived, and use the formula_renames.json mecanism from brew. Do you agree ?

@kvendingoldo
Copy link
Collaborator Author

@dvaumoron yep, I absolutely agree with you. I can do it today, or you can do it by yourself. Also, I will add the information to tofuenv readme.

@dvaumoron
Copy link
Contributor

Ok, I will do that.

@dvaumoron
Copy link
Contributor

Updated the readme and added formula_renames.json, however i can not change gotofuenv repository in an archived one, I will let you do it.

@kvendingoldo
Copy link
Collaborator Author

@dvaumoron I think that it's time to close this issue :) Great work!

@kvendingoldo
Copy link
Collaborator Author

Done by @dvaumoron

@kvendingoldo kvendingoldo added the enhancement New feature or request label Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants