-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace external tofuenv to a native Go support #8
Comments
Hi @kvendingoldo, Just seen you create this issue to continue our exchange started in tofuutils/tofuenv#31 |
@dvaumoron yep. Today's I gonna upload basic layout to |
@dvaumoron I've added a basic layout for UPD: I've updated the code inside of main branch, now it partially support |
@dvaumoron wdyt? |
I am first working on adding Terraform support to gotofuenv, the progress are fast. After that (probably during next week), an eventual reorganization of commands will be easier. |
@dvaumoron that sounds fantastic! Are you planning to merge your code with tenv after that? For the time being, I notice that we are doing nearly identical job, which is inefficient in my opinion. |
The refactor with a ReleaseInfoRetriever interface will allow a better reusability of the code (if we want to keep same kind of functionnality for OpenTofu and Terraform) I don't understand why you call it inefficiency, my work is not hidden, its location of availability doesn't change much. |
Hi @kvendingoldo, I released gotofuenv v1.0.0, I will slow down on it for now (only fix bugs if needed). Before going further, I wonder, what do you envision for tenv ? What do you think should be done differently ? |
Hello @dvaumoron! I wanted to express my admiration for your incredible work. In my previous comment, I was talking about my team's work as about smth not very useful because your code looks almost the same as we realized. Please accept my apologies for any unintended negative tone, and I genuinely commend your outstanding contribution to the migration of tofu/tf env to Golang. We was waiting news from your side and for this reason we stopped tenv development for a while. My team still want to keep the original idea of this united tool inside of tofuutils organization and develop / promote and enhance it together in the future. What's your thougts about the future of tool that you have written? Don't you want to migrate it to the tofuutils organisation and be a primary maintainer of it? |
As said on Slack, I am ready to migrate, but when trying to transfer that did not work yet ("You don’t have the permission to create public repositories on tofuutils"). |
@dvaumoron can you check it now, please? I sent you an invitation. |
I started to update after the transfer to tofuutils, I launched a release, the brew part failed. |
@dvaumoron pls, check again. I fixed permissions |
Everything seem to work as expected now (including the brew migration part in dvaumoron/tap, not sure there is a lot of users concerned except me, but that still better). I followed your suggestion and renamed the managing command |
@dvaumoron I merged your repo to |
I have no objection, however i have some questions. Now, my work has been merge in the tenv repo, it seems appropriate to indicate in the gotofuenv readme that the work will continue there, mark it as archived, and use the formula_renames.json mecanism from brew. Do you agree ? |
@dvaumoron yep, I absolutely agree with you. I can do it today, or you can do it by yourself. Also, I will add the information to tofuenv readme. |
Ok, I will do that. |
Updated the readme and added formula_renames.json, however i can not change gotofuenv repository in an archived one, I will let you do it. |
@dvaumoron I think that it's time to close this issue :) Great work! |
Done by @dvaumoron |
No description provided.
The text was updated successfully, but these errors were encountered: