Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Activity label breaks, when tag added to 0 keys #2418

Closed
stepan662 opened this issue Jul 23, 2024 · 7 comments · Fixed by #2433
Closed

Activity label breaks, when tag added to 0 keys #2418

stepan662 opened this issue Jul 23, 2024 · 7 comments · Fixed by #2433
Assignees

Comments

@stepan662
Copy link
Contributor

Snímek obrazovky 2024-07-23 v 17 35 45
@JanCizmar
Copy link
Contributor

Is this frontend or backend issue?

@stepan662
Copy link
Contributor Author

I didn't investigate much further, I think there is some issue with the statistics returned from the backend, there is some value KeyCount, which is normally a number and in this case is missing. For other batch operations it seems to be there, but not for this one. Can be fixed on the FE, but would be nice if it would behave consistently.

@huglx
Copy link
Collaborator

huglx commented Aug 12, 2024

I'll look into that 🙂

@huglx
Copy link
Collaborator

huglx commented Aug 12, 2024

@stepan662 can you please help me with reproducing this bug. Thanks:)

@stepan662
Copy link
Contributor Author

It happens when the batch operation adds 0 tags (can happen if the keys are already tagged with the same tag)

Zaznam.obrazovky.2024-08-13.v.9.13.00.mov

@huglx
Copy link
Collaborator

huglx commented Aug 13, 2024

@JanCizmar, @stepan662 Is it okay if I just throw an exception when adding a tag to 0 keys? Or is this a useful feature (idk why)?

@stepan662
Copy link
Contributor Author

No, we shouldn't throw any errors, it's a valid case that can happen. We might skip activity creation all together (as basically nothing changed). But maybe we should tell the user how many keys were actually updated - however if this is complicated, I think it's enough to just not to create activity.

@huglx huglx linked a pull request Aug 20, 2024 that will close this issue
@JanCizmar JanCizmar assigned JanCizmar and unassigned huglx Aug 20, 2024
@JanCizmar JanCizmar assigned huglx and unassigned JanCizmar Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants