-
-
Notifications
You must be signed in to change notification settings - Fork 201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Activity label breaks, when tag added to 0 keys #2418
Comments
Is this frontend or backend issue? |
I didn't investigate much further, I think there is some issue with the statistics returned from the backend, there is some value |
I'll look into that 🙂 |
@stepan662 can you please help me with reproducing this bug. Thanks:) |
It happens when the batch operation adds 0 tags (can happen if the keys are already tagged with the same tag) Zaznam.obrazovky.2024-08-13.v.9.13.00.mov |
@JanCizmar, @stepan662 Is it okay if I just throw an exception when adding a tag to 0 keys? Or is this a useful feature (idk why)? |
No, we shouldn't throw any errors, it's a valid case that can happen. We might skip activity creation all together (as basically nothing changed). But maybe we should tell the user how many keys were actually updated - however if this is complicated, I think it's enough to just not to create activity. |
The text was updated successfully, but these errors were encountered: