Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refresh of DefinitelyTyped #26

Open
srunnoe opened this issue Dec 20, 2020 · 0 comments
Open

Refresh of DefinitelyTyped #26

srunnoe opened this issue Dec 20, 2020 · 0 comments

Comments

@srunnoe
Copy link

srunnoe commented Dec 20, 2020

Tomasz,

Forgive me if I got this wrong, but it appears as though the mirror of this repo under DefinitelyTyped is stale. I tried including it in my project via DefinitelyTyped and noticed that ModelFields is outdated and resulted in compile errors.

New variant....
export type ModelFields = M['__fields'];

Stale in
https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/types/redux-orm/Model.d.ts

Fixed in
https://github.com/tomasz-zablocki/redux-orm-types/blob/master/types/redux-orm/Model.d.ts

I spent a lot of time trying to fix it myself before realizing that you already had a fix in place. Learned a lot along the way. Writing declaration files is a tough business, thanks for all your hard work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant