Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rust support #7

Open
ghost opened this issue Oct 21, 2017 · 8 comments
Open

Rust support #7

ghost opened this issue Oct 21, 2017 · 8 comments

Comments

@ghost
Copy link

ghost commented Oct 21, 2017

Currently only comments are highlighted, it'd be great to have full support

@tonsky
Copy link
Owner

tonsky commented Oct 21, 2017

Strings and numbers (constants) are too. This is a minimalist theme, I don’t highlight anything else apart from those and comments.

screen shot 2017-10-21 at 22 36 15

@ghost
Copy link
Author

ghost commented Oct 22, 2017

Oh, I get it. So, the only thing that is missing are the global definitions (as stated in the README)? For example, on the following photo A, B, C, D, E, F, G, H and i:
image

@tonsky
Copy link
Owner

tonsky commented Oct 22, 2017

This is a problem with Rust syntax plugin for VS Code. It doesn’t mark up function definition differently from function invocation. And I want to highlight definitions only (entity.global class in syntax)

@tonsky
Copy link
Owner

tonsky commented Oct 22, 2017

Upon further research, the class should probably be named meta.definition (meta.definition.function.rust and meta.definition.type.rust). I could add that to the theme, but Rust syntax would still need to be updated. Also I’ll need to update Clojure syntax because it puts meta.definition at the wrong token. After that I could update the theme

@ghost
Copy link
Author

ghost commented Oct 23, 2017

^ is this correct? (microsoft/vscode#36748)

@tonsky
Copy link
Owner

tonsky commented Oct 23, 2017

I think it should be both: entity.name and meta.definition. You can specify multiple classes:

"name": "entity.name.function.rust meta.definition.function.rust"

tonsky added a commit that referenced this issue Nov 27, 2017
@tonsky
Copy link
Owner

tonsky commented Nov 27, 2017

Waiting on atom/language-clojure#75

tonsky added a commit that referenced this issue Nov 27, 2017
@ghost
Copy link
Author

ghost commented Nov 28, 2017

also zargony/atom-language-rust#123
I'm not sure if they'll ever merge it though, it looks dead

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant