-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option to return SUCCEED when training is completed with some failed job tasks #420
Comments
Agreed, but I am refrained from making the APIs over complicated, any thought on how the configurations would look like? |
@oliverhu I also agreed that it's better to simplify the APIs, or we can cancel this configuration and all completed application with failure tasks will return SUCCEEDED, which is more reasonable. |
CI failed with following logs: Maybe test has been run too long? |
Not sure, will take a look tmr |
Assign to Ankit to follow up on this issue |
App will be stopped when chief worker (or some certain jobtype), and continue training when other job task fails. It looks reasonable.
But in this circumstance, training is finished and return FAILED on YARN.
I think it's a contradiction.
If we will continue training after one worker fails, and training is finally completed, why should it return FAILED?
Users would feel confused, and don't know what they should do next. Rerun training for more accurate model, or use this model with a FAILED status?
They could config #412 if they needs fail fast, while return SUCCEED when training is completed if they needs training to continue.
I believe it is better to add an extra option for whether return SUCCEED or FAILED when training is completed with some failed job tasks, which user can specify on a per-job basis.
The text was updated successfully, but these errors were encountered: