From b86e74106d89646a95d6f119d523f22f15490398 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?David=20S=C3=A1nchez?= Date: Thu, 9 Nov 2023 11:48:20 +0100 Subject: [PATCH] [Security Solution] [Endpoint] Cypress Increase create policy task timeout (#170001) ## Summary Increase policy task timeout to 5 minutes to avoid flaky tests. ### For maintainers - [ ] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) --------- Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> --- .../response_console/execute.cy.ts | 3 +-- ...olicy_details_with_security_essentials.cy.ts | 9 ++++++--- .../public/management/cypress/tasks/fleet.ts | 17 +++++++++++------ 3 files changed, 18 insertions(+), 11 deletions(-) diff --git a/x-pack/plugins/security_solution/public/management/cypress/e2e/response_actions/response_console/execute.cy.ts b/x-pack/plugins/security_solution/public/management/cypress/e2e/response_actions/response_console/execute.cy.ts index d43037f4d7f978..dad573bb09c2bf 100644 --- a/x-pack/plugins/security_solution/public/management/cypress/e2e/response_actions/response_console/execute.cy.ts +++ b/x-pack/plugins/security_solution/public/management/cypress/e2e/response_actions/response_console/execute.cy.ts @@ -21,8 +21,7 @@ import { enableAllPolicyProtections } from '../../../tasks/endpoint_policy'; import { createEndpointHost } from '../../../tasks/create_endpoint_host'; import { deleteAllLoadedEndpointData } from '../../../tasks/delete_all_endpoint_data'; -// FLAKY: https://github.com/elastic/kibana/issues/170373 -describe.skip('Response console', { tags: ['@ess', '@serverless'] }, () => { +describe('Response console', { tags: ['@ess', '@serverless'] }, () => { beforeEach(() => { login(); }); diff --git a/x-pack/plugins/security_solution/public/management/cypress/e2e/serverless/policy_details_with_security_essentials.cy.ts b/x-pack/plugins/security_solution/public/management/cypress/e2e/serverless/policy_details_with_security_essentials.cy.ts index efb48f65435425..36ebb060454c5a 100644 --- a/x-pack/plugins/security_solution/public/management/cypress/e2e/serverless/policy_details_with_security_essentials.cy.ts +++ b/x-pack/plugins/security_solution/public/management/cypress/e2e/serverless/policy_details_with_security_essentials.cy.ts @@ -9,8 +9,7 @@ import { login } from '../../tasks/login'; import { visitPolicyDetailsPage } from '../../screens/policy_details'; import type { IndexedFleetEndpointPolicyResponse } from '../../../../../common/endpoint/data_loaders/index_fleet_endpoint_policy'; -// FLAKY: https://github.com/elastic/kibana/issues/170666 -describe.skip( +describe( 'When displaying the Policy Details in Security Essentials PLI', { tags: ['@serverless'], @@ -24,7 +23,11 @@ describe.skip( let loadedPolicyData: IndexedFleetEndpointPolicyResponse; before(() => { - cy.task('indexFleetEndpointPolicy', { policyName: 'tests-serverless' }).then((response) => { + cy.task( + 'indexFleetEndpointPolicy', + { policyName: 'tests-serverless' }, + { timeout: 5 * 60 * 1000 } + ).then((response) => { loadedPolicyData = response as IndexedFleetEndpointPolicyResponse; }); }); diff --git a/x-pack/plugins/security_solution/public/management/cypress/tasks/fleet.ts b/x-pack/plugins/security_solution/public/management/cypress/tasks/fleet.ts index 8f1da4a0ec020c..bc0f94d7120584 100644 --- a/x-pack/plugins/security_solution/public/management/cypress/tasks/fleet.ts +++ b/x-pack/plugins/security_solution/public/management/cypress/tasks/fleet.ts @@ -81,15 +81,20 @@ export const yieldEndpointPolicyRevision = (): Cypress.Chainable => export const createAgentPolicyTask = ( version: string, - policyPrefix?: string + policyPrefix?: string, + timeout?: number ): Cypress.Chainable => { const policyName = `${policyPrefix || 'Reassign'} ${Math.random().toString(36).substring(2, 7)}`; - return cy.task('indexFleetEndpointPolicy', { - policyName, - endpointPackageVersion: version, - agentPolicyName: policyName, - }); + return cy.task( + 'indexFleetEndpointPolicy', + { + policyName, + endpointPackageVersion: version, + agentPolicyName: policyName, + }, + { timeout: timeout ?? 5 * 60 * 1000 } + ); }; export const enableAgentTamperProtectionFeatureFlagInPolicy = (agentPolicyId: string) => {