Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tool is not working in internet explorer #44

Open
RishikaBhatia17 opened this issue Mar 15, 2020 · 2 comments
Open

Tool is not working in internet explorer #44

RishikaBhatia17 opened this issue Mar 15, 2020 · 2 comments

Comments

@RishikaBhatia17
Copy link
Contributor

The bug
The tool is not working in internet explorer as expected.

To Reproduce
Steps to reproduce the behavior:

  1. Go to https://tools.wmflabs.org/google-drive-photos-to-commons/
  2. Accept privacy policy and click on the button "Start Uploading"

Expected behavior
The user should be redirected to the "Login to Wikimedia Commons" button page

Actual Behavior
The user is being redirected to an abnormal user interface where three buttons are being displayed at same time as shown below.

image

Desktop:

  • OS: Windows 10
  • Internet Explorer
  • Version 11.657.18362.0
@abbasidaniyal
Copy link
Contributor

This is interesting. The page looks like this because there is some JavaScript error as the show/hide section code fails. Can you check and verify what is the console output?

@abbasidaniyal
Copy link
Contributor

abbasidaniyal commented Mar 19, 2020

Turns out, the error is caused by "`" symbol used for template strings. Internet Explorer does not support template strings. It is working fine on Microsoft Edge, which is the recommended browser by Microsoft.
@tonythomas01 Should we refactor the code for Internet Explorer?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants