From 9f75ae95987c23f87a203522e8d52f9a6120a5ff Mon Sep 17 00:00:00 2001 From: topjohnwu Date: Sun, 11 Sep 2022 14:46:16 -0700 Subject: [PATCH] Invert logic --- .../src/main/java/com/topjohnwu/superuser/internal/Utils.java | 4 ++-- .../main/java/com/topjohnwu/superuser/ipc/RootService.java | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/core/src/main/java/com/topjohnwu/superuser/internal/Utils.java b/core/src/main/java/com/topjohnwu/superuser/internal/Utils.java index b8be6c69..1e3575fc 100644 --- a/core/src/main/java/com/topjohnwu/superuser/internal/Utils.java +++ b/core/src/main/java/com/topjohnwu/superuser/internal/Utils.java @@ -173,8 +173,8 @@ synchronized static void setConfirmedRootState(boolean value) { currentRootState = value ? 2 : 0; } - public static boolean isRootPossible() { - return !Objects.equals(isAppGrantedRoot(), Boolean.FALSE); + public static boolean isRootImpossible() { + return Objects.equals(isAppGrantedRoot(), Boolean.FALSE); } public static boolean isMainShellRoot() { diff --git a/service/src/main/java/com/topjohnwu/superuser/ipc/RootService.java b/service/src/main/java/com/topjohnwu/superuser/ipc/RootService.java index 9237f617..1e2856f1 100644 --- a/service/src/main/java/com/topjohnwu/superuser/ipc/RootService.java +++ b/service/src/main/java/com/topjohnwu/superuser/ipc/RootService.java @@ -107,7 +107,7 @@ public static void bind( @NonNull Intent intent, @NonNull Executor executor, @NonNull ServiceConnection conn) { - if (!Utils.isRootPossible()) + if (Utils.isRootImpossible()) return; Shell.Task task = bindOrTask(intent, executor, conn); if (task != null) { @@ -168,7 +168,7 @@ public static void unbind(@NonNull ServiceConnection conn) { */ @MainThread public static void stop(@NonNull Intent intent) { - if (!Utils.isRootPossible()) + if (Utils.isRootImpossible()) return; Shell.Task task = stopOrTask(intent); if (task != null) {