-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Align formatting of annotations #248
Comments
Thanks for the suggestion! |
Hi, |
Hmmm. I think we can change it for some internal names. But changing the external interface is risky and I would like to keep it as is. |
Never mind, this was just a suggestion, it's OK if you don't feel like changing it. Thx for the feedback. |
What
This may sound a bit stupid, but I'm wondering if we could align the formatting of the different annotations.
Some use hyphens (
inodes-threshold
,initial-resize-group-by
, ..) while other use underscores (storage_limit
,pre_capacity_bytes
), which can be confusing.The standard seems to be hyphens from what I've seen.
How
Update the few annotations that use underscores and replaces them with hyphens.
We might want to support both for some time to avoid breaking changes?
If you're OK with the idea, I'd be happy to contribute.
The text was updated successfully, but these errors were encountered: