Add set -o errexit -o nounset to shell scripts

For #33604

Author: c-chroniko

scripts/git/pre-commit.git-hook

@@ -10,7 +10,8 @@ workdir=$(git rev-parse --show-toplevel)
 
 cd "$workdir" || exit 1
 
-set -e
+set -o errexit
+set -o nounset
 
 if [ -e tests/shellcheck-tests.sh ]; then
     tests/shellcheck-tests.sh

tests/shellcheck-tests.sh

@@ -1,7 +1,7 @@
 #!/bin/sh
 
-# Exit on errors
-set -e
+set -o errexit
+set -o nounset
 
 # SC1117 was disabled after 0.5, because it was too pedantic
 EXCLUSIONS="--exclude=SC1117"

tests/unit-tests.sh

@@ -1,7 +1,7 @@
 #!/bin/sh
 
-# Exit on errors
-set -e
+set -o errexit
+set -o nounset
 
 # Output is prefixed with the name of the script
 myname=$(basename "$0")

tools/bootstrap-network.sh

@@ -12,6 +12,9 @@
 #    network-flavour: one of the files in the networks directory,
 #                     (default: 'bridges+hs-v23')
 
+set -o errexit
+set -o nounset
+
 # Get a working chutney path
 if [ ! -d "$CHUTNEY_PATH" ] || [ ! -x "$CHUTNEY_PATH/chutney" ]; then
     # looks like a broken path: use the path to this tool instead

tools/diagnostics.sh

@@ -17,6 +17,9 @@
 #    tools/diagnostics.sh
 #    tools/diagnostics.sh 001a
 
+set -o errexit
+set -o nounset
+
 if [ ! -d "$CHUTNEY_PATH" ] || [ ! -x "$CHUTNEY_PATH/chutney" ]; then
     # looks like a broken path: use the path to this tool instead
     TOOLS_PATH=$(dirname "$0")

tools/hsaddress.sh

@@ -7,6 +7,9 @@
 # Examples: tools/hsaddress.sh
 #           tools/hsaddress.sh 025h
 
+set -o errexit
+set -o nounset
+
 if [ ! -d "$CHUTNEY_PATH" ] || [ ! -x "$CHUTNEY_PATH/chutney" ]; then
     # looks like a broken path: use the path to this tool instead
     TOOLS_PATH=$(dirname "$0")

tools/test-network-impl.sh

@@ -1,5 +1,8 @@
 #!/bin/sh
 
+set -o errexit
+set -o nounset
+
 if ! "$CHUTNEY_PATH/tools/bootstrap-network.sh" "$NETWORK_FLAVOUR"; then
     if test "$?" = 77; then
 	$ECHO "SKIP: $NETWORK_FLAVOUR not supported."

tools/test-network.sh

@@ -1,5 +1,8 @@
 #!/bin/sh
 
+set -o errexit
+set -o nounset
+
 export ECHO="${ECHO:-echo}"
 
 # Output is prefixed with the name of the script

tools/warnings.sh

@@ -25,6 +25,9 @@
 #    CHUTNEY_WARNINGS_SKIP:
 #        set to "true" to skip all warnings
 
+set -o errexit
+set -o nounset
+
 if [ "$CHUTNEY_WARNINGS_SKIP" = true ]; then
     exit 0
 fi