You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
After looking at the source code more closely I would like to put up the following suggested roadmap items up for discussion:
Tag definitions in pages: Currently tags need to be provided as comma separated lists and it is not possible to use arrays or lists of tags in the frontmatter. I am not sure what the added value of comma separated lists is since they require more processing than arrays or lists.
Pagination: The pagination basically duplicates functionality of metalsmith-pagination. It might be a good idea to remove pagination from metalsmith-tags and focus on generating the global tags metadata in a way that is compatible with metalsmith-pagination. metalsmith-tags would still be responsible for creating tag pages without pagination, but it would leave the pagination to the other plugin. The documentation would need provide an example on how to apply metalsmith-pagination afterwards.
Add ESLint configuration: I would be great if the project includes an ESLint configuration. This would make it easier for contributors to ensure their code is neat and clean and also be helpful for maintainers when merging pull requests. I have no preference which ESLint configuration to use as long as the code is consistent. eslint-config-standard is one of many options.
Conversion to ES2015: I think it's time to convert this project (like all other Metalsmith projects) to ES2015. This would require a Babel build step to create the npm package ES5 compliant.
The text was updated successfully, but these errors were encountered:
I would also suggest that you add a list of tag names to the global metadata so that when not on tag pages you can still build a tag cloud in the sidebar. I am currently having a hard time getting at this data and am looking at the following
1.) writing a custom plugin
2.) submitting a pull request
After looking at the source code more closely I would like to put up the following suggested roadmap items up for discussion:
metalsmith-pagination
. It might be a good idea to remove pagination frommetalsmith-tags
and focus on generating the globaltags
metadata in a way that is compatible withmetalsmith-pagination
.metalsmith-tags
would still be responsible for creating tag pages without pagination, but it would leave the pagination to the other plugin. The documentation would need provide an example on how to applymetalsmith-pagination
afterwards.eslint-config-standard
is one of many options.The text was updated successfully, but these errors were encountered: