Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display all assignments on Code Review Dashboard if logged in as Instructor #8

Open
tp02ga opened this issue Oct 3, 2022 · 0 comments

Comments

@tp02ga
Copy link
Owner

tp02ga commented Oct 3, 2022

Background / Purpose

Within the Code Reviewer Dashboard, currently, we list assignments in the following statuses:

  • In Review (for the currently logged-in code reviewer)
  • Awaiting Review
  • Needs Update (for the currently logged-in code reviewer)

This causes a problem for the instructors (ROLE_INSTRUCTOR) as the instructors are sometimes not the ones performing the code reviews, and therefore they cannot see the "In Review" and "Needs Update" assignments that are currently assigned to other code reviewers (ROLE_CODE_REVIEWER)

Suggested Solution

In the Code Reviewer Dashboard (/src/CodeReviewerDashboard/index.js), when logged in as an instructor (ROLE_INSTRUCTOR) and ONLY when logged in as an instructor, we should display (almost) all assignments without filtering by the code reviewer's user_id field.

Inside AssignmentService there is a findByUser method that currently behaves differently if you are a code reviewer or a student. You'll need to add another behavior that returns all assignments if the logged-in user is an instructor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant