tcti-spi-helper: check callback pointers

NULL pointers will cause an NPD error, check all the pointers for sanity
on initialization.

Signed-off-by: William Roberts <william.c.roberts@intel.com>

Author: William Roberts

src/tss2-tcti/tcti-spi-helper.c

@@ -430,6 +430,24 @@ static void spi_tpm_helper_fifo_transfer(TSS2_TCTI_SPI_HELPER_CONTEXT* ctx, uint
     } while (handled_so_far != transfer_size);
 }
 
+static TSS2_RC check_platform_conf(TSS2_TCTI_SPI_HELPER_PLATFORM *platform_conf)
+{
+
+    bool required_set = platform_conf->sleep_ms && platform_conf->spi_transfer \
+            && platform_conf->start_timeout && platform_conf->timeout_expired;
+    if (!required_set) {
+        LOG_ERROR("Expected sleep_ms, spi_transfer, start_timeout and timeout_expired to be set.");
+        return TSS2_TCTI_RC_BAD_VALUE;
+    }
+
+    if (!!platform_conf->spi_acquire != !!platform_conf->spi_release) {
+        LOG_ERROR("Expected spi_acquire and spi_release to both be NULL or set.");
+        return TSS2_TCTI_RC_BAD_VALUE;
+    }
+
+    return TSS2_RC_SUCCESS;
+}
+
 /*
  * This function wraps the "up-cast" of the opaque TCTI context type to the
  * type for the device TCTI context. The only safe-guard we have to ensure
@@ -675,6 +693,9 @@ TSS2_RC Tss2_Tcti_Spi_Helper_Init (TSS2_TCTI_CONTEXT* tcti_context, size_t* size
     memset (&tcti_common->header, 0, sizeof (tcti_common->header));
     tcti_common->locality = 0;
 
+    rc = check_platform_conf(platform_conf);
+    return_if_error(rc, "platform_conf invalid");
+
     // Copy platform struct into context
     tcti_spi_helper->platform = *platform_conf;
 

test/unit/tcti-spi-helper.c

@@ -260,13 +260,67 @@ tcti_spi_with_wait_state_success_test (void **state)
     free (tcti_ctx);
 }
 
+static void
+tcti_spi_with_bad_callbacks_test (void **state)
+{
+    TSS2_RC rc;
+    size_t size;
+    TSS2_TCTI_SPI_HELPER_PLATFORM tcti_platform = {};
+    TSS2_TCTI_CONTEXT* tcti_ctx;
+
+    // Get requested TCTI context size
+    rc = Tss2_Tcti_Spi_Helper_Init (NULL, &size, &tcti_platform);
+    assert_int_equal (rc, TSS2_RC_SUCCESS);
+
+    // Allocate TCTI context size
+    tcti_ctx = (TSS2_TCTI_CONTEXT*) calloc (1, size);
+    assert_non_null (tcti_ctx);
+
+    // Initialize TCTI context
+    tcti_platform = create_tcti_spi_helper_platform (false);
+    tcti_platform.sleep_ms = NULL;
+    rc = Tss2_Tcti_Spi_Helper_Init (tcti_ctx, &size, &tcti_platform);
+    assert_int_equal (rc, TSS2_TCTI_RC_BAD_VALUE);
+
+    free (tcti_platform.user_data);
+    free (tcti_ctx);
+}
+
+static void
+tcti_spi_with_wait_state_bad_callbacks_test (void **state)
+{
+    TSS2_RC rc;
+    size_t size;
+    TSS2_TCTI_SPI_HELPER_PLATFORM tcti_platform = {};
+    TSS2_TCTI_CONTEXT* tcti_ctx;
+
+    // Get requested TCTI context size
+    rc = Tss2_Tcti_Spi_Helper_Init (NULL, &size, &tcti_platform);
+    assert_int_equal (rc, TSS2_RC_SUCCESS);
+
+    // Allocate TCTI context size
+    tcti_ctx = (TSS2_TCTI_CONTEXT*) calloc (1, size);
+    assert_non_null (tcti_ctx);
+
+    // Initialize TCTI context
+    tcti_platform = create_tcti_spi_helper_platform (true);
+    tcti_platform.spi_acquire = NULL;
+    rc = Tss2_Tcti_Spi_Helper_Init (tcti_ctx, &size, &tcti_platform);
+    assert_int_equal (rc, TSS2_TCTI_RC_BAD_VALUE);
+
+    free (tcti_platform.user_data);
+    free (tcti_ctx);
+}
+
 int
 main (int   argc,
       char *argv[])
 {
     const struct CMUnitTest tests[] = {
         cmocka_unit_test (tcti_spi_no_wait_state_success_test),
         cmocka_unit_test (tcti_spi_with_wait_state_success_test),
+        cmocka_unit_test (tcti_spi_with_bad_callbacks_test),
+        cmocka_unit_test (tcti_spi_with_wait_state_bad_callbacks_test)
     };
     return cmocka_run_group_tests (tests, NULL, NULL);
 }