fix review

Author: cp-20

model/comments.go

@@ -1,6 +1,6 @@
 package model
 
-import "fmt"
+import "errors"
 
 type Comment struct {
 	GormModel
@@ -21,21 +21,21 @@ type CreateCommentPayload struct {
 
 func CreateComment(p *CreateCommentPayload) (*Comment, error) {
 	if p.ItemID == 0 {
-		return nil, fmt.Errorf("ItemID is required")
+		return nil, errors.New("ItemID is required")
 	}
 	if p.UserID == "" {
-		return nil, fmt.Errorf("UserID is required")
+		return nil, errors.New("UserID is required")
 	}
 	if p.Comment == "" {
-		return nil, fmt.Errorf("Comment is required")
+		return nil, errors.New("Comment is required")
 	}
-	c := &Comment{
+	c := Comment{
 		ItemID:  p.ItemID,
 		UserID:  p.UserID,
 		Comment: p.Comment,
 	}
-	if err := db.Create(c).Error; err != nil {
+	if err := db.Create(&c).Error; err != nil {
 		return nil, err
 	}
-	return c, nil
+	return &c, nil
 }

model/comments_test.go

@@ -12,7 +12,7 @@ func TestCreateComment(t *testing.T) {
 	cases := []struct {
 		name    string
 		payload *CreateCommentPayload
-		fail    bool
+		ok      bool
 	}{
 		{
 			name: "正常系",
@@ -21,39 +21,39 @@ func TestCreateComment(t *testing.T) {
 				UserID:  "user1",
 				Comment: "comment1",
 			},
-			fail: false,
+			ok: true,
 		},
 		{
 			name: "異常系: ItemIDが存在しない",
 			payload: &CreateCommentPayload{
 				UserID:  "user1",
 				Comment: "comment1",
 			},
-			fail: true,
+			ok: false,
 		},
 		{
 			name: "異常系: UserIDが存在しない",
 			payload: &CreateCommentPayload{
 				ItemID:  1,
 				Comment: "comment1",
 			},
-			fail: true,
+			ok: false,
 		},
 		{
 			name: "異常系: Commentが存在しない",
 			payload: &CreateCommentPayload{
 				ItemID: 1,
 				UserID: "user1",
 			},
-			fail: true,
+			ok: false,
 		},
 	}
 
 	assert := assert.New(t)
 	for _, tt := range cases {
 		t.Run(tt.name, func(t *testing.T) {
 			_, err := CreateComment(tt.payload)
-			if tt.fail {
+			if tt.ok {
 				assert.Error(err)
 			} else {
 				assert.NoError(err)

router/comments.go

@@ -2,6 +2,7 @@ package router
 
 import (
 	"fmt"
+	"net/http"
 	"strconv"
 
 	"github.com/labstack/echo/v4"
@@ -18,8 +19,8 @@ type PostCommentResponse struct {
 
 // PostComment POST /items/:id/comments
 func PostComment(c echo.Context) error {
-	itemIDRaw := c.Param("id")
-	itemID, err := strconv.Atoi(itemIDRaw)
+	itemIDStr := c.Param("id")
+	itemID, err := strconv.Atoi(itemIDStr)
 	if err != nil {
 		return invalidRequest(c, err)
 	}
@@ -44,5 +45,5 @@ func PostComment(c echo.Context) error {
 		return internalServerError(c, err)
 	}
 
-	return c.JSON(201, PostCommentResponse{ID: comment.ID})
+	return c.JSON(http.StatusCreated, PostCommentResponse{ID: comment.ID})
 }

router/comments_test.go

@@ -1,6 +1,7 @@
 package router
 
 import (
+	"net/http"
 	"testing"
 
 	"github.com/labstack/echo/v4"
@@ -12,7 +13,7 @@ func TestPostComment(t *testing.T) {
 	model.PrepareTestDatabase()
 
 	e := echo.New()
-	SetupRouting(e, CreateUserProvider("s9"))
+	SetupRouting(e, CreateUserProvider(TEST_USER))
 
 	cases := []struct {
 		name     string
@@ -22,24 +23,24 @@ func TestPostComment(t *testing.T) {
 		{
 			name:     "正常系",
 			payload:  `{"text":"テストコメント"}`,
-			expected: 201,
+			expected: http.StatusCreated,
 		},
 		{
 			name:     "異常系: 空文字列",
 			payload:  `{"text":""}`,
-			expected: 400,
+			expected: http.StatusBadRequest,
 		},
 		{
 			name:     "異常系: パラメータ不足",
 			payload:  `{}`,
-			expected: 400,
+			expected: http.StatusBadRequest,
 		},
 	}
 
 	for _, tc := range cases {
 		t.Run(tc.name, func(t *testing.T) {
 			assert := assert.New(t)
-			rec := PerformMutation(e, "POST", "/api/items/1/comments", tc.payload)
+			rec := performMutation(e, "POST", "/api/items/1/comments", tc.payload)
 			assert.Equal(tc.expected, rec.Code)
 		})
 	}

router/test_common.go renamed to router/util_test.go

@@ -7,7 +7,9 @@ import (
 	"github.com/labstack/echo/v4"
 )
 
-func PerformMutation(e *echo.Echo, method, path, payload string) *httptest.ResponseRecorder {
+var TEST_USER = "s9"
+
+func performMutation(e *echo.Echo, method, path, payload string) *httptest.ResponseRecorder {
 	req := httptest.NewRequest(method, path, strings.NewReader(payload))
 	req.Header.Set("Content-Type", "application/json")
 	rec := httptest.NewRecorder()