Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔧 deprecatedだったfail_on_errorをfail_levelに変更 #1084

Merged
merged 1 commit into from
Dec 30, 2024

Conversation

ikura-hamu
Copy link
Member

@ikura-hamu ikura-hamu commented Dec 30, 2024

PR Type

configuration changes


Description

  • .github/workflows/ci.yaml内で、非推奨となったfail_on_errorfail_levelに変更しました。
  • reviewdog/action-golangci-lintの設定を最新の推奨形式に更新しました。

Changes walkthrough 📝

Relevant files
Configuration changes
ci.yaml
非推奨の`fail_on_error`を`fail_level`に置き換え                                       

.github/workflows/ci.yaml

  • fail_on_errorが非推奨となったため、fail_levelに変更。
  • reviewdog/action-golangci-lintの設定を更新。
  • +1/-1     

    💡 PR-Agent usage: Comment /help "your question" on any pull request to receive relevant information

    Copy link

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ Recommended focus areas for review

    Configuration Update Validation

    Ensure that the replacement of fail_on_error with fail_level is compatible with the current version of reviewdog/action-golangci-lint and behaves as expected.

    fail_level: any

    Copy link

    PR Code Suggestions ✨

    Explore these optional code suggestions:

    CategorySuggestion                                                                                                                                    Score
    General
    設定値fail_levelが意図した動作をするか確認し、適切な値に修正します。

    fail_levelの値としてanyを指定していますが、これは意図した動作を引き起こすか確認してください。anyが適切でない場合、正しいレベルを選択してください。

    .github/workflows/ci.yaml [61]

    -fail_level: any
    +fail_level: error
    Suggestion importance[1-10]: 6

    Why: The suggestion prompts the user to verify if the fail_level: any setting behaves as intended and proposes changing it to error if necessary. While it is actionable and relevant, it does not provide concrete evidence that any is incorrect, making the impact moderate.

    6

    @ikura-hamu ikura-hamu merged commit d259446 into main Dec 30, 2024
    9 checks passed
    @ikura-hamu ikura-hamu deleted the conf/reviewdog_fail_level branch December 30, 2024 12:07
    Copy link

    codecov bot commented Dec 30, 2024

    Codecov Report

    All modified and coverable lines are covered by tests ✅

    Project coverage is 49.85%. Comparing base (26ed9ef) to head (ad31221).
    Report is 2 commits behind head on main.

    Additional details and impacted files
    @@           Coverage Diff           @@
    ##             main    #1084   +/-   ##
    =======================================
      Coverage   49.85%   49.85%           
    =======================================
      Files         121      121           
      Lines       10986    10986           
    =======================================
      Hits         5477     5477           
      Misses       5171     5171           
      Partials      338      338           

    ☔ View full report in Codecov by Sentry.
    📢 Have feedback on the report? Share it here.

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    1 participant