Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔧 ai reviewで自動生成されるコードを無視するように設定 #990

Merged
merged 1 commit into from
Sep 23, 2024

Conversation

ikura-hamu
Copy link
Member

@ikura-hamu ikura-hamu commented Sep 21, 2024

PR Type

configuration changes


Description

  • .github/workflows/ai-review.yamlにおいて、IGNORE.GLOB['*.gen.go']を追加し、自動生成されるGoコードを無視するように設定を変更。

Changes walkthrough 📝

Relevant files
Configuration changes
ai-review.yaml
自動生成コードを無視する設定の追加                                                                               

.github/workflows/ai-review.yaml

  • IGNORE.GLOB['*.gen.go']を追加
+1/-0     

💡 PR-Agent usage:
Comment /help on the PR to get a list of all available PR-Agent tools and their descriptions

Copy link

PR Reviewer Guide 🔍

⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ No key issues to review

Copy link

github-actions bot commented Sep 21, 2024

PR Code Suggestions ✨

CategorySuggestion                                                                                                                                    Score
Possible issue
クォートを外して、配列として正しく解釈させる

IGNORE.GLOB
の値が文字列として解釈されている可能性があります。YAMLではシングルクォートやダブルクォートを使用すると、中の内容が文字列として扱われます。配列として正しく解釈させるためには、クォートを外す必要があります。

.github/workflows/ai-review.yaml [37]

-IGNORE.GLOB: "['*.gen.go']"
+IGNORE.GLOB: [*.gen.go]
 
Suggestion importance[1-10]: 9

Why: The suggestion correctly identifies that the quotes around the array in YAML can cause it to be interpreted as a string rather than an array. Removing the quotes ensures that the value is correctly interpreted as an array.

9

Copy link

codecov bot commented Sep 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.09%. Comparing base (855c1e7) to head (0c7b6e7).
Report is 8 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #990   +/-   ##
=======================================
  Coverage   55.09%   55.09%           
=======================================
  Files         159      159           
  Lines       11694    11694           
=======================================
  Hits         6443     6443           
  Misses       4829     4829           
  Partials      422      422           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ikura-hamu
Copy link
Member Author

/config

Copy link

🛠️ PR-Agent Configurations:
==================== CONFIG ====================
config.enable_custom_labels = False  
config.model = 'gpt-4-turbo-2024-04-09'  
config.model_turbo = 'gpt-4o-2024-08-06'  
config.fallback_models = ['gpt-4o-2024-05-13']  
config.git_provider = 'github'  
config.publish_output = True  
config.publish_output_progress = True  
config.verbosity_level = 0  
config.use_extra_bad_extensions = False  
config.use_wiki_settings_file = True  
config.use_repo_settings_file = True  
config.use_global_settings_file = True  
config.ai_timeout = 120  
config.max_description_tokens = 500  
config.max_commits_tokens = 500  
config.max_model_tokens = 32000  
config.custom_model_max_tokens = -1  
config.patch_extension_skip_types = ['.md', '.txt']  
config.allow_dynamic_context = True  
config.max_extra_lines_before_dynamic_context = 8  
config.patch_extra_lines_before = 3  
config.patch_extra_lines_after = 1  
config.cli_mode = False  
config.output_relevant_configurations = False  
config.large_patch_policy = 'clip'  
config.seed = -1  
config.temperature = 0.2  
config.ignore_pr_title = ['^\\[Auto\\]', '^Auto']  
config.ignore_pr_target_branches = []  
config.ignore_pr_source_branches = []  
config.ignore_pr_labels = []  
config.is_auto_command = False  
config.enable_ai_metadata = False  

==================== PR_REVIEWER ====================
pr_reviewer.extra_instructions = '必ず日本語で回答してください'  
pr_reviewer.require_score_review = False  
pr_reviewer.require_tests_review = True  
pr_reviewer.require_estimate_effort_to_review = True  
pr_reviewer.require_can_be_split_review = False  
pr_reviewer.require_security_review = True  
pr_reviewer.require_soc2_ticket = False  
pr_reviewer.soc2_ticket_prompt = 'Does the PR description include a link to ticket in a project management system (e.g., Jira, Asana, Trello, etc.) ?'  
pr_reviewer.num_code_suggestions = 0  
pr_reviewer.inline_code_comments = False  
pr_reviewer.ask_and_reflect = False  
pr_reviewer.persistent_comment = True  
pr_reviewer.final_update_message = True  
pr_reviewer.enable_review_labels_security = True  
pr_reviewer.enable_review_labels_effort = True  
pr_reviewer.require_all_thresholds_for_incremental_review = False  
pr_reviewer.minimal_commits_for_incremental_review = 0  
pr_reviewer.minimal_minutes_for_incremental_review = 0  
pr_reviewer.enable_help_text = False  
pr_reviewer.enable_auto_approval = False  
pr_reviewer.maximal_review_effort = 5  

==================== PR_DESCRIPTION ====================
pr_description.extra_instructions = 'Please use Japanese in descriptions.'  
pr_description.publish_labels = False  
pr_description.add_original_user_description = True  
pr_description.generate_ai_title = False  
pr_description.use_bullet_points = True  
pr_description.enable_pr_type = True  
pr_description.final_update_message = True  
pr_description.enable_help_text = False  
pr_description.enable_help_comment = True  
pr_description.publish_description_as_comment = False  
pr_description.publish_description_as_comment_persistent = True  
pr_description.enable_semantic_files_types = True  
pr_description.collapsible_file_list = 'adaptive'  
pr_description.inline_file_summary = False  
pr_description.use_description_markers = False  
pr_description.include_generated_by_header = True  
pr_description.enable_large_pr_handling = True  
pr_description.max_ai_calls = 4  
pr_description.async_ai_calls = True  
pr_description.mention_extra_files = True  

==================== PR_QUESTIONS ====================
pr_questions.enable_help_text = False  

==================== PR_CODE_SUGGESTIONS ====================
pr_code_suggestions.extra_instructions = 'Please use Japanese in descriptions.'  
pr_code_suggestions.max_context_tokens = 14000  
pr_code_suggestions.num_code_suggestions = 4  
pr_code_suggestions.commitable_code_suggestions = False  
pr_code_suggestions.rank_suggestions = False  
pr_code_suggestions.enable_help_text = False  
pr_code_suggestions.persistent_comment = True  
pr_code_suggestions.max_history_len = 4  
pr_code_suggestions.apply_suggestions_checkbox = True  
pr_code_suggestions.self_reflect_on_suggestions = True  
pr_code_suggestions.suggestions_score_threshold = 0  
pr_code_suggestions.auto_extended_mode = True  
pr_code_suggestions.num_code_suggestions_per_chunk = 4  
pr_code_suggestions.max_number_of_calls = 3  
pr_code_suggestions.parallel_calls = True  
pr_code_suggestions.rank_extended_suggestions = False  
pr_code_suggestions.final_clip_factor = 0.8  
pr_code_suggestions.demand_code_suggestions_self_review = False  
pr_code_suggestions.code_suggestions_self_review_text = '**Author self-review**: I have reviewed the PR code suggestions, and addressed the relevant ones.'  
pr_code_suggestions.approve_pr_on_self_review = False  
pr_code_suggestions.publish_post_process_suggestion_impact = True  

==================== PR_CUSTOM_PROMPT ====================
pr_custom_prompt.prompt = 'The code suggestions should focus only on the following:\n- ...\n- ...\n...\n'  
pr_custom_prompt.suggestions_score_threshold = 0  
pr_custom_prompt.num_code_suggestions_per_chunk = 4  
pr_custom_prompt.self_reflect_on_custom_suggestions = True  
pr_custom_prompt.enable_help_text = False  

==================== PR_ADD_DOCS ====================
pr_add_docs.extra_instructions = ''  
pr_add_docs.docs_style = 'Sphinx'  
pr_add_docs.file = ''  
pr_add_docs.class_name = ''  

==================== PR_UPDATE_CHANGELOG ====================
pr_update_changelog.push_changelog_changes = False  
pr_update_changelog.extra_instructions = ''  

==================== PR_ANALYZE ====================
pr_analyze.enable_help_text = True  

==================== PR_TEST ====================
pr_test.extra_instructions = ''  
pr_test.testing_framework = ''  
pr_test.num_tests = 3  
pr_test.avoid_mocks = True  
pr_test.file = ''  
pr_test.class_name = ''  
pr_test.enable_help_text = False  

==================== PR_IMPROVE_COMPONENT ====================
pr_improve_component.num_code_suggestions = 4  
pr_improve_component.extra_instructions = ''  
pr_improve_component.file = ''  
pr_improve_component.class_name = ''  

==================== PR_SIMILAR_ISSUE ====================
pr_similar_issue.skip_comments = False  
pr_similar_issue.force_update_dataset = False  
pr_similar_issue.max_issues_to_scan = 500  
pr_similar_issue.vectordb = 'pinecone'  

==================== PR_FIND_SIMILAR_COMPONENT ====================
pr_find_similar_component.class_name = ''  
pr_find_similar_component.file = ''  
pr_find_similar_component.search_from_org = False  
pr_find_similar_component.allow_fallback_less_words = True  
pr_find_similar_component.number_of_keywords = 5  
pr_find_similar_component.number_of_results = 5  

@ikura-hamu
Copy link
Member Author

動いてるかわかんないけど、動いてなかったらその時修正する

@ikura-hamu ikura-hamu merged commit 32e624c into main Sep 23, 2024
11 checks passed
@ikura-hamu ikura-hamu deleted the conf/ai-review-ignore branch September 23, 2024 02:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant