Check if email is required before fetching from LDAP to prevent key error

[ByteSquire]

I am getting following error:

in __getitem__
    return self._store[self._case_insensitive_keymap[self._ci_key(key)]]
KeyError: 'mail'

because this doesn't check if mail is required for login

tracim/backend/tracim_backend/lib/core/user.py

Line 618 in 3d43244

if self._config.LDAP_MAIL_ATTRIBUTE:

I suggest following change:

if self._config.EMAIL_REQUIRED and self._config.LDAP_MAIL_ATTRIBUTE:

[piRGoif]

Hello,
Thanks for your feedback !

This is a known default.
The documentation talks a little about the problem (see for example https://github.com/tracim/tracim/blob/develop/docs/administration/installation/settings_main_topics.md#authentication-in-tracim).

The solution cannot be to disable the email.required parameter if using LDAP auth though as some instances requires both features to be enabled.
There are indeed ways to improve the behavior to give users and admin some guidance...