Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support child lookups #1

Closed
martinheidegger opened this issue Feb 22, 2022 · 3 comments · May be fixed by #3
Closed

Support child lookups #1

martinheidegger opened this issue Feb 22, 2022 · 3 comments · May be fixed by #3
Labels
enhancement New feature or request

Comments

@martinheidegger
Copy link
Contributor

Currently the plugin system loads only the index/main code. To support multiple plugins in one dependency, it needs to also allow to load a sub-dependency (via. name) here, with a proposed API of:

plugin.data(opts?: { force?: boolean, child?: string }): Promise<any>

This should best support the entire plugin options to prevent unexpected behavior.
@martinheidegger martinheidegger added the enhancement New feature or request label Feb 22, 2022
@martinheidegger martinheidegger mentioned this issue Feb 22, 2022
Draft
@urbien
Copy link
Member

urbien commented Apr 20, 2022

could you clarify why we need to package multiple plugins in one dependency?
the way I see it is each plugin is a tarball with all of its own dependencies. It can be loaded separately from other plugins using npm install from the tarball.

@martinheidegger
Copy link
Contributor Author

There is no inherent need to package multiple plugins in one dependency. The advantage that it has is that the configuration becomes simpler and likely faster because of that:

Pseudo mycloud configuration setup:

plugins: 
  - mycompany-private-plugin-a
  - mycompany-private-plugin-b
  - mycompany-private-plugin-c
  - mycompany-private-plugin-d

vs one single package installed

plugins:
   - mycompany-private-plugins

I think the idea in this PR is sound, but for now I intend not to work on it (its not part of my POC efforts anymore)

@urbien
Copy link
Member

urbien commented Apr 26, 2022

closing as this feature is not needed at this point

@urbien urbien closed this as completed Apr 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: adding support for child lookups tradle/lambda-plugins
2 participants
@martinheidegger @urbien