-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
default_url_options as a configuration requirement #60
Comments
Sounds like a good idea to delegate that per default. No, eh, what do you mean? Did the roar-rails README ever contain docs about HAL? Or are you talking about the roar README? |
Sorry yeah the roar readme
|
Rewriting it, with first-level HAL chapter. Do you want me to put a photo of you (top-less?) into it? 😬 |
Do you mean to change this line from Rails.application.config.representer.default_url_options or {} to Rails.application.config.representer.default_url_options or
Rails.application.config.action_controller.default_url_options ? |
You read my mind - this is exactly why I brought this up ;) Just checking. I brought up the README for some example usage and couldn't
|
Yeah that's the sort of change I was getting at. I wondered if you had
|
Can you paste a |
Not connected to the matrix right now but will try and remember tomorrow
|
The thing is, I now wonder how people actually use the |
|
We serve different APIs at different endpoints, for example: api.host.com The subdomain gets set as part of the We also define the host and protocol, but those aren't really significant (they don't change). |
@mikekelly Put a huge chapter about HAL into the README, retweet appreciated! |
And I still need to know your |
@apotonick just a quick one.. working on a new API and wondering about the reasons why the
default_url_options
config option is a requirement and you weren't able to delegate this to Rails by default?also - you dropped hal from the readme! 😢
The text was updated successfully, but these errors were encountered: