Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: CallConversion not catching malformed calls #756

Open
shinlee03 opened this issue Dec 30, 2024 · 1 comment
Open

[Bug]: CallConversion not catching malformed calls #756

shinlee03 opened this issue Dec 30, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@shinlee03
Copy link

shinlee03 commented Dec 30, 2024

VAST version

wintern branch

LLVM version

19.1.5

Operating system

macOS

Description

Related issue: #753

I'm currently printing out all callees within matchAndRewrite to verify names used by vast.

When converting hl.calls with signatures in form \01_xx, CallConversion fails to produce any output.

Steps to Reproduce

Compiled test.c:

#include <fcntl.h>
#include <unistd.h>

void test(int name) {
    close(name);
}

vast-front -DHAVE_CONFIG_H -I. -g -O2 -c -o test.mlir test.c -vast-emit-mlir=hl -vast-simplify -vast-show-locs -vast-loc-attrs

Then vast-detect-parsers test.mlir --vast-hl-to-parser -reconcile-unrealized-casts -o vast.parser.mlir.

@shinlee03 shinlee03 added the bug Something isn't working label Dec 30, 2024
@shinlee03
Copy link
Author

matchAndRewrite also fails to catch non-malformed calls.

Steps to Reproduce

Compile lib/chdir-long.c of gzip (1.10) to hl, then to parser. cdb_advance_fd call is missing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant