Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use pure-java HTTP client instead of OkHttp? #250

Open
exoego opened this issue Feb 6, 2023 · 1 comment
Open

Use pure-java HTTP client instead of OkHttp? #250

exoego opened this issue Feb 6, 2023 · 1 comment
Labels
dependencies Pull requests that update a dependency file

Comments

@exoego
Copy link
Contributor

exoego commented Feb 6, 2023 •
edited
Loading

OkHttp v4 is written in Kotlin.
If we version up OkHttp to v4 or later, we need to depend on kotlin-stdlib transitively.
@exoego exoego added the dependencies Pull requests that update a dependency file label Feb 6, 2023
@xerial
Copy link
Member

xerial commented May 18, 2023 •
edited
Loading

@exoego This can be a good approach to avoid dependency issues around okhttp and Kotlin. I've tested the pure-java HTTP client (available since Java9) at airframe-http and it works well out of the box https://github.com/wvlet/airframe/blob/master/airframe-http/.jvm/src/main/scala/wvlet/airframe/http/client/JavaHttpClientChannel.scala

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@xerial @exoego