From a041c48af00b0b820517b904fc17c899e30ad896 Mon Sep 17 00:00:00 2001
From: Caleb White <cdwhite3@pm.me>
Date: Tue, 1 Oct 2024 08:16:34 -0500
Subject: [PATCH] feat: add asymmetric property visibility

---
 common/define-grammar.js | 15 ++++++--
 test/corpus/class.txt    | 79 ++++++++++++++++++++++++++++++++++++++++
 2 files changed, 90 insertions(+), 4 deletions(-)

diff --git a/common/define-grammar.js b/common/define-grammar.js
index 48697339..7a0e6827 100644
--- a/common/define-grammar.js
+++ b/common/define-grammar.js
@@ -423,10 +423,17 @@ module.exports = function defineGrammar(dialect) {
         ),
       ),
 
-      visibility_modifier: _ => choice(
-        keyword('public'),
-        keyword('protected'),
-        keyword('private'),
+      visibility_modifier: $ => seq(
+        choice(
+          keyword('public'),
+          keyword('protected'),
+          keyword('private'),
+        ),
+        optional(seq(
+          token.immediate('('),
+          alias($.name, $.operation),
+          token.immediate(')'),
+        )),
       ),
 
       function_definition: $ => seq(
diff --git a/test/corpus/class.txt b/test/corpus/class.txt
index 38f2fbe8..f00f886c 100644
--- a/test/corpus/class.txt
+++ b/test/corpus/class.txt
@@ -1010,3 +1010,82 @@ class User implements Named {
                   (name))))
             (name)
             (compound_statement)))))))
+
+=========================================
+Asymmetric Property Visibility
+=========================================
+
+<?php
+
+class User {
+    public private(set) string $foo;
+    private(set) (Foo&Bar)|null $foo;
+    private (Foo&Bar)|null $foo;
+    public protected(set) string $foo;
+    protected(set) string $foo;
+    public function __construct(
+        private(set) string $title,
+        private(set) Author $author,
+        private(set) int $pubYear,
+    ) {}
+}
+
+---
+
+(program
+  (php_tag)
+  (class_declaration
+    (name)
+    (declaration_list
+      (property_declaration
+        (visibility_modifier)
+        (visibility_modifier (operation))
+        (primitive_type)
+        (property_element
+          (variable_name (name))))
+      (property_declaration
+        (visibility_modifier (operation))
+        (disjunctive_normal_form_type
+          (intersection_type
+            (named_type (name))
+            (named_type (name)))
+          (primitive_type))
+        (property_element
+          (variable_name (name))))
+      (property_declaration
+        (visibility_modifier)
+        (disjunctive_normal_form_type
+          (intersection_type
+            (named_type (name))
+            (named_type (name)))
+          (primitive_type))
+        (property_element
+          (variable_name (name))))
+      (property_declaration
+        (visibility_modifier)
+        (visibility_modifier (operation))
+        (primitive_type)
+        (property_element
+          (variable_name (name))))
+      (property_declaration
+        (visibility_modifier (operation))
+        (primitive_type)
+        (property_element
+          (variable_name (name))))
+      (method_declaration
+        (visibility_modifier)
+        (name)
+        (formal_parameters
+          (property_promotion_parameter
+            (visibility_modifier (operation))
+            (primitive_type)
+            (variable_name (name)))
+          (property_promotion_parameter
+            (visibility_modifier (operation))
+            (named_type (name))
+            (variable_name (name)))
+          (property_promotion_parameter
+            (visibility_modifier (operation))
+            (primitive_type)
+            (variable_name (name))))
+        (compound_statement)))))