Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is telemetry really needed? #114

Closed
maximlt opened this issue Oct 16, 2023 · 2 comments
Closed

Is telemetry really needed? #114

maximlt opened this issue Oct 16, 2023 · 2 comments

Comments

@maximlt
Copy link

maximlt commented Oct 16, 2023

Hi @alex-treebeard,

I've been looking for a Pytest plugin to run notebooks and found your project to be an interesting alternative to e.g nbval. Looking at the repo I found out that you recently added some telemetry in #113. Even if it seems it's possible to deactivate it, I found that very surprising for an open-source project of this dimension. I usually see bigger projects implementing telemetry, they're usually backed by some start-up/company and need data to report progress to their investors. I don't know if this is the case for nbmake. To me at least, this is definitely a red flag and discards nbmake as a tool I would add to my testing framework.

@alex-treebeard
Copy link
Member

alex-treebeard commented Oct 16, 2023

Hi @maximlt, this is a question I have asked myself quite a bit.

These are the high-level reasons I recently made this change:

  1. It lets me understand the usage of the project better, this is necessary for prioritising issues and generally helping the community
  2. I found that other projects, even non-commercial ones also do this (similarly transparently)
  3. This project now requires a non-trivial amount of resources from (admittedly a tiny) for-profit company

I'm sorry you feel this is a red flag. IMO it reflects a paradigm shift in (a) how people make product decisions in open source project, and (b) the increasingly commercial aspect of open source.

For context: I am working on more powerful adjacent offerings to nbmake. This is financially risky but I do it because I like to serve developers like you -- telemetry helps bound the risk.

From your perspective, does this make you feel any more comfortable with the decision? Is there are better middle ground I could strike here?

E: Disabled telemetry by default. My main goal with this was to verify that this was actually being used (not just downloaded). I determined it was being invoked ~4K every weekday.

@alex-treebeard
Copy link
Member

removed the disabled metrics code in #115, closing this, thanks for the feedback

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants