Merge pull request #813 from memorysafety/clippy-update

updates to pass 1.75 version of clippy

Author: squell

src/common/command.rs

@@ -63,7 +63,7 @@ impl CommandAndArguments {
                 arguments = vec!["-c".to_string(), escaped(arguments)]
             }
         } else {
-            command = arguments.get(0).map(|s| s.into()).unwrap_or_default();
+            command = arguments.first().map(|s| s.into()).unwrap_or_default();
             arguments.remove(0);
 
             // remember the original binary name before resolving symlinks; this is not

src/common/error.rs

@@ -25,7 +25,7 @@ pub enum Error {
     Configuration(String),
     Options(String),
     Pam(PamError),
-    IoError(Option<PathBuf>, std::io::Error),
+    Io(Option<PathBuf>, std::io::Error),
     MaxAuthAttempts(usize),
     PathValidation(PathBuf),
     StringValidation(String),
@@ -64,7 +64,7 @@ impl fmt::Display for Error {
             Error::Configuration(e) => write!(f, "invalid configuration: {e}"),
             Error::Options(e) => write!(f, "{e}"),
             Error::Pam(e) => write!(f, "PAM error: {e}"),
-            Error::IoError(location, e) => {
+            Error::Io(location, e) => {
                 if let Some(path) = location {
                     write!(f, "cannot execute '{}': {e}", path.display())
                 } else {
@@ -98,7 +98,7 @@ impl From<PamError> for Error {
 
 impl From<std::io::Error> for Error {
     fn from(err: std::io::Error) -> Self {
-        Error::IoError(None, err)
+        Error::Io(None, err)
     }
 }
 

src/sudo/pipeline.rs

@@ -86,7 +86,7 @@ impl<Policy: PolicyPlugin, Auth: AuthPlugin> Pipeline<Policy, Auth> {
             log_command_execution(&context);
 
             crate::exec::run_command(&context, target_env)
-                .map_err(|io_error| Error::IoError(Some(context.command.command), io_error))
+                .map_err(|io_error| Error::Io(Some(context.command.command), io_error))
         } else {
             Err(Error::CommandNotFound(context.command.command))
         };