Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Projection.Module.genericInstantiationsByDefinition to cover nongeneric types #287

Closed
tristanlabelle opened this issue Sep 15, 2024 · 1 comment
Closed

Refactor Projection.Module.genericInstantiationsByDefinition to cover nongeneric types #287

tristanlabelle opened this issue Sep 15, 2024 · 1 comment
Labels
cleanup Code cleanup or refactoring

Comments

@tristanlabelle
Copy link
Owner

tristanlabelle commented Sep 15, 2024 •
edited
Loading

Nongeneric types are instantiated with an empty array of generic arguments, so this should make the code more uniform.

This could be achieved using a Module.TypeEntry nested type that has a definition a set of instantiations.
@tristanlabelle tristanlabelle added the cleanup Code cleanup or refactoring label Sep 15, 2024
@tristanlabelle
Copy link
Owner Author

Implemented indirectly via Module.getTypeInstantiations in #348 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cleanup Code cleanup or refactoring
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tristanlabelle