Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Format error shouldn't prevent tests from running #4

Closed
sloede opened this issue Jan 29, 2024 · 2 comments · Fixed by #6
Closed

Format error shouldn't prevent tests from running #4

sloede opened this issue Jan 29, 2024 · 2 comments · Fixed by #6

Comments

@sloede
Copy link
Member

sloede commented Jan 29, 2024

What's the rationale behind stopping all tests if the format is wrong? My dev workflow is often incremental, thus I do a little thing, push, then come back later once tests have run. If the only thing missing the formatting while all functional tests are green, I usually just apply the formatter and immediately request a review.

IMHO, we should either make the format check a separate run on a single OS, or move it to the end of the tests. I prefer the former. Thoughts @efaulhaber @ranocha ?

@ranocha
Copy link
Member

ranocha commented Jan 29, 2024

I also prefer the first option. IIRC, @efaulhaber told me that he uses it like it is since that saves CI time in private repositories - fail fast if anything isn't correct.

@efaulhaber
Copy link
Member

Yes, that's what we use for TrixiParticles to avoid wasting CI time when the run will fail anyway.

@sloede sloede closed this as completed in #6 Jan 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants