Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

whitespace around = in kwargs #7

Merged
merged 5 commits into from
Jan 30, 2024
Merged

whitespace around = in kwargs #7

merged 5 commits into from
Jan 30, 2024

Conversation

ranocha
Copy link
Member

@ranocha ranocha commented Jan 29, 2024

For consistency with Trixi.jl

Copy link

codecov bot commented Jan 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0e8161a) 93.65% compared to head (22e568e) 93.65%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main       #7   +/-   ##
=======================================
  Coverage   93.65%   93.65%           
=======================================
  Files           4        4           
  Lines          63       63           
=======================================
  Hits           59       59           
  Misses          4        4           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

sloede
sloede previously approved these changes Jan 29, 2024
Copy link
Member

@sloede sloede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given the majority of the code in the Trixi Framework is currently formatted this way, I think this is the right move.

sloede
sloede previously approved these changes Jan 29, 2024
Copy link

github-actions bot commented Jan 29, 2024

Pull Request Test Coverage Report for Build 7698756899

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 93.651%

Totals Coverage Status
Change from base Build 7698753991: 0.0%
Covered Lines: 59
Relevant Lines: 63

💛 - Coveralls

efaulhaber
efaulhaber previously approved these changes Jan 29, 2024
@sloede sloede enabled auto-merge (squash) January 29, 2024 15:52
@sloede
Copy link
Member

sloede commented Jan 29, 2024

@ranocha sorry, I might have re-re-re-formatted during merge conflict resolution... can you please format once more?

@sloede sloede dismissed stale reviews from efaulhaber and themself via 39a6071 January 30, 2024 12:22
@sloede sloede merged commit 1dc5a93 into main Jan 30, 2024
15 checks passed
@sloede sloede deleted the hr/space_around_kwargs branch January 30, 2024 12:27
@ranocha
Copy link
Member Author

ranocha commented Jan 30, 2024

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants