Skip to content

Commit 2016359

Browse files
authored
Merge pull request #51 from yas-okadatech/feature/update_v16
bump Google Ads SDK to 30.0.0 (support for Google Ads API v16.0)
2 parents 036925b + 9fd8a59 commit 2016359

File tree

6 files changed

+86
-7
lines changed

6 files changed

+86
-7
lines changed
Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
# This is a Gradle generated file for dependency locking.
2+
# Manual edits can break the build and are not advised.
3+
# This file is expected to be part of source control.

shadow-google-ads-helper/build.gradle

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ configurations {
3030
}
3131

3232
dependencies {
33-
compile("com.google.api-ads:google-ads:26.1.0") {
33+
compile("com.google.api-ads:google-ads:30.0.0") {
3434
exclude group: "commons-logging", module: "commons-logging"
3535
}
3636

@@ -47,3 +47,13 @@ shadowJar {
4747
relocate "com.google.thirdparty.publicsuffix", "embulk.google-ads.com.google.thirdparty.publicsuffix"
4848
relocate "com.fasterxml.jackson", "embulk.google-ads.com.fasterxml.jackson"
4949
}
50+
51+
// https://github.com/google/guava/issues/6612#issuecomment-1614992368
52+
sourceSets.all {
53+
configurations.getByName(runtimeClasspathConfigurationName) {
54+
attributes.attribute(Attribute.of("org.gradle.jvm.environment", String), "standard-jvm")
55+
}
56+
configurations.getByName(compileClasspathConfigurationName) {
57+
attributes.attribute(Attribute.of("org.gradle.jvm.environment", String), "standard-jvm")
58+
}
59+
}
Lines changed: 63 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,63 @@
1+
# This is a Gradle generated file for dependency locking.
2+
# Manual edits can break the build and are not advised.
3+
# This file is expected to be part of source control.
4+
com.google.android:annotations:4.1.1.4
5+
com.google.api-ads:google-ads-codegen:30.0.0
6+
com.google.api-ads:google-ads-stubs-lib:30.0.0
7+
com.google.api-ads:google-ads-stubs-v14:30.0.0
8+
com.google.api-ads:google-ads-stubs-v15:30.0.0
9+
com.google.api-ads:google-ads-stubs-v16:30.0.0
10+
com.google.api-ads:google-ads:30.0.0
11+
com.google.api.grpc:proto-google-common-protos:2.34.0
12+
com.google.api:api-common:2.26.0
13+
com.google.api:gax-grpc:2.43.0
14+
com.google.api:gax:2.43.0
15+
com.google.auth:google-auth-library-credentials:1.23.0
16+
com.google.auth:google-auth-library-oauth2-http:1.23.0
17+
com.google.auto.service:auto-service-annotations:1.0.1
18+
com.google.auto.service:auto-service:1.0.1
19+
com.google.auto.value:auto-value-annotations:1.10.4
20+
com.google.auto:auto-common:1.2
21+
com.google.cloud:google-cloud-shared-dependencies:3.25.0
22+
com.google.code.findbugs:jsr305:3.0.2
23+
com.google.code.gson:gson:2.10.1
24+
com.google.errorprone:error_prone_annotations:2.24.1
25+
com.google.guava:failureaccess:1.0.1
26+
com.google.guava:guava:32.1.3-jre
27+
com.google.guava:listenablefuture:9999.0-empty-to-avoid-conflict-with-guava
28+
com.google.http-client:google-http-client-gson:1.44.1
29+
com.google.http-client:google-http-client:1.44.1
30+
com.google.j2objc:j2objc-annotations:2.8
31+
com.google.protobuf:protobuf-java-util:3.25.2
32+
com.google.protobuf:protobuf-java:3.25.2
33+
com.google.re2j:re2j:1.7
34+
com.squareup:javapoet:1.11.1
35+
commons-codec:commons-codec:1.16.1
36+
io.grpc:grpc-alts:1.61.1
37+
io.grpc:grpc-api:1.61.1
38+
io.grpc:grpc-auth:1.61.1
39+
io.grpc:grpc-context:1.61.1
40+
io.grpc:grpc-core:1.61.1
41+
io.grpc:grpc-googleapis:1.61.1
42+
io.grpc:grpc-grpclb:1.61.1
43+
io.grpc:grpc-inprocess:1.61.1
44+
io.grpc:grpc-netty-shaded:1.61.1
45+
io.grpc:grpc-protobuf-lite:1.61.1
46+
io.grpc:grpc-protobuf:1.61.1
47+
io.grpc:grpc-services:1.61.1
48+
io.grpc:grpc-stub:1.61.1
49+
io.grpc:grpc-util:1.61.1
50+
io.grpc:grpc-xds:1.61.1
51+
io.opencensus:opencensus-api:0.31.1
52+
io.opencensus:opencensus-contrib-http-util:0.31.1
53+
io.opencensus:opencensus-proto:0.2.0
54+
io.perfmark:perfmark-api:0.27.0
55+
javax.annotation:javax.annotation-api:1.3.2
56+
org.apache.httpcomponents:httpclient:4.5.14
57+
org.apache.httpcomponents:httpcore:4.4.16
58+
org.checkerframework:checker-qual:3.42.0
59+
org.codehaus.mojo:animal-sniffer-annotations:1.23
60+
org.conscrypt:conscrypt-openjdk-uber:2.5.2
61+
org.slf4j:jcl-over-slf4j:1.7.12
62+
org.slf4j:slf4j-api:1.7.25
63+
org.threeten:threetenbp:1.6.8
Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
# This is a Gradle generated file for dependency locking.
2+
# Manual edits can break the build and are not advised.
3+
# This file is expected to be part of source control.

src/main/java/org/embulk/input/google_ads/GoogleAdsInputPlugin.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
package org.embulk.input.google_ads;
22

3-
import com.google.ads.googleads.v14.services.GoogleAdsRow;
4-
import com.google.ads.googleads.v14.services.GoogleAdsServiceClient;
3+
import com.google.ads.googleads.v16.services.GoogleAdsRow;
4+
import com.google.ads.googleads.v16.services.GoogleAdsServiceClient;
55
import com.google.common.collect.ImmutableList;
66

77
import org.embulk.config.ConfigDiff;

src/main/java/org/embulk/input/google_ads/GoogleAdsReporter.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -7,9 +7,9 @@
77
import com.fasterxml.jackson.databind.node.JsonNodeType;
88
import com.fasterxml.jackson.databind.node.ObjectNode;
99
import com.google.ads.googleads.lib.GoogleAdsClient;
10-
import com.google.ads.googleads.v14.services.GoogleAdsRow;
11-
import com.google.ads.googleads.v14.services.GoogleAdsServiceClient;
12-
import com.google.ads.googleads.v14.services.SearchGoogleAdsRequest;
10+
import com.google.ads.googleads.v16.services.GoogleAdsRow;
11+
import com.google.ads.googleads.v16.services.GoogleAdsServiceClient;
12+
import com.google.ads.googleads.v16.services.SearchGoogleAdsRequest;
1313
import com.google.auth.oauth2.UserCredentials;
1414
import com.google.common.base.CaseFormat;
1515
import com.google.protobuf.Descriptors;
@@ -61,7 +61,7 @@ private Iterable<GoogleAdsServiceClient.SearchPage> search(Map<String, String> p
6161
String query = buildQuery(task, params);
6262
logger.info(query);
6363
SearchGoogleAdsRequest request = buildRequest(task, query);
64-
GoogleAdsServiceClient googleAdsService = client.getVersion14().createGoogleAdsServiceClient();
64+
GoogleAdsServiceClient googleAdsService = client.getVersion16().createGoogleAdsServiceClient();
6565
GoogleAdsServiceClient.SearchPagedResponse response = googleAdsService.search(request);
6666
return response.iteratePages();
6767
}

0 commit comments

Comments
 (0)