Retrieve field type from schema if a specied column does not exist in column_options #45
+311
−211
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yas-okadatech
commented
Aug 5, 2024
|
Logic for SUBTABLE also needs to be modified, so I coverted back to draft. |
kentoyoshida
approved these changes
Aug 8, 2024
yas-okadatech
force-pushed
the
25678-schema
branch
from
66ef64a to
f1e5edc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
retrieve field type from schema if a specied column does not exist in column_options.
e.g) if data is string type, embulk-output-kintone treats it as MULTI_LINE_TEXT but actually it may be SINGLE_LINE_TEXT. And kintone API / SDK show warning message about wrong type.