Skip to content

Commit 7f0b184

Browse files
committed
impr(test): revert changes and optimize those tests in a safer way
1 parent 2a3d5ca commit 7f0b184

File tree

2 files changed

+11
-11
lines changed

2 files changed

+11
-11
lines changed

framework/src/test/java/org/tron/common/runtime/vm/BatchValidateSignContractTest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,6 @@ public void staticCallTest() {
7979

8080
@Test
8181
public void correctionTest() {
82-
contract.setConstantCall(true);
8382
List<Object> signatures = new ArrayList<>();
8483
List<Object> addresses = new ArrayList<>();
8584
byte[] hash = Hash.sha3(longData);
@@ -128,7 +127,8 @@ Pair<Boolean, byte[]> validateMultiSign(byte[] hash, List<Object> signatures,
128127
List<Object> parameters = Arrays.asList("0x" + Hex.toHexString(hash), signatures, addresses);
129128
byte[] input = Hex.decode(AbiUtil.parseParameters(METHOD_SIGN, parameters));
130129
contract.getEnergyForData(input);
131-
contract.setVmShouldEndInUs(System.nanoTime() / 1000 + 500 * 1000);
130+
long maxExecutionTime = 2000; // ms
131+
contract.setVmShouldEndInUs(System.nanoTime() / 1000 + maxExecutionTime * 1000);
132132
Pair<Boolean, byte[]> ret = contract.execute(input);
133133
logger.info("BytesArray:{},HexString:{}", Arrays.toString(ret.getValue()),
134134
Hex.toHexString(ret.getValue()));

framework/src/test/java/org/tron/common/runtime/vm/Create2Test.java

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -161,15 +161,15 @@ public void testCreate2()
161161
long salt = 100L;
162162
String hexInput = AbiUtil.parseMethod(methodSign, Arrays.asList(testCode, salt));
163163

164-
TVMTestResult result = null;
165-
for (int i = 1; i < 3; i++) {
166-
result = TvmTestUtils
167-
.triggerContractAndReturnTvmTestResult(Hex.decode(OWNER_ADDRESS),
168-
factoryAddress, Hex.decode(hexInput), 0, fee, manager, null);
169-
if (result.getRuntime().getRuntimeError() == null) {
170-
break;
171-
}
172-
}
164+
long preTime = manager.getDynamicPropertiesStore().getMaxCpuTimeOfOneTx();
165+
// set max cpu time to 500
166+
manager.getDynamicPropertiesStore().saveMaxCpuTimeOfOneTx(500L);
167+
TVMTestResult result = TvmTestUtils
168+
.triggerContractAndReturnTvmTestResult(Hex.decode(OWNER_ADDRESS),
169+
factoryAddress, Hex.decode(hexInput), 0, fee, manager, null);
170+
// restore max cpu time
171+
manager.getDynamicPropertiesStore().saveMaxCpuTimeOfOneTx(preTime);
172+
173173
Assert.assertNull(result.getRuntime().getRuntimeError());
174174

175175
byte[] returnValue = result.getRuntime().getResult().getHReturn();

0 commit comments

Comments
 (0)