Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

This doesn't make any sense. #3

Open
kashishgrover opened this issue Nov 29, 2018 · 4 comments
Open

This doesn't make any sense. #3

kashishgrover opened this issue Nov 29, 2018 · 4 comments

Comments

@kashishgrover
Copy link

kashishgrover commented Nov 29, 2018

In point 4 in your integration steps, you say that

  1. Add the above extracted .aar file into libs folder of your react-native-truecaller (path : react-native-truecaller -> android -> libs -> .arr file)

This doesn't make any sense because node modules are never pushed to the codebase. I am not sure why you would even think of asking users to edit them. What if someone else clones my repo and runs an npm install? The app would break for them because they wouldn't have the said .arr file in their node modules.

I hope you guys fix this. I would say it is just better to do a native integration after seeing this package.

@kashishgrover
Copy link
Author

Oh wait there's more.

  1. Add you partner key in react-native-truecaller manifest file

I'm sorry. 😂

@sauravsolanki
Copy link

sauravsolanki commented Jun 24, 2019

error: cannot find symbol
import com.truecaller.android.sdk.TrueClient;
^
symbol: class TrueClient
location: package com.truecaller.android.sdk

There is no true client class present. What to do?

@sauravsolanki
Copy link

Oh wait there's more.

  1. Add you partner key in react-native-truecaller manifest file

I'm sorry.

I think it means app key, not partner key

@anujmpec
Copy link

Is anything available related to new documents?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants