Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix] Close modal button cannot be overridden #3092

Open
jaredcunha opened this issue Jan 7, 2025 · 0 comments
Open

[fix] Close modal button cannot be overridden #3092

jaredcunha opened this issue Jan 7, 2025 · 0 comments
Labels
type: bug Something isn't working like it's supposed to

Comments

@jaredcunha
Copy link

ReactUSWDS Version & USWDS Version:

Describe the bug

The text to close the modal cannot be overridden, so in a spanish translated site, the control is announced in English on screen readers.

Expected behavior

A prop can be provided to override close button name. This would also be helpful for overriding the english copy as well.

Screenshots

Additional context

Device and Browser Information (please complete the following information if describing a UI bug):
@jaredcunha jaredcunha added the type: bug Something isn't working like it's supposed to label Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: bug Something isn't working like it's supposed to
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jaredcunha