Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

arcf_config_free(): don't assert conf->conf_refcnt == 0 #147

Open
glts opened this issue Jul 25, 2021 · 0 comments
Open

arcf_config_free(): don't assert conf->conf_refcnt == 0 #147

glts opened this issue Jul 25, 2021 · 0 comments

Comments

@glts
Copy link

glts commented Jul 25, 2021

See trusteddomainproject/OpenDKIM#22.

diff --git a/openarc/openarc.c b/openarc/openarc.c
--- a/openarc/openarc.c
+++ b/openarc/openarc.c
@@ -1326,7 +1326,6 @@ static void
 arcf_config_free(struct arcf_config *conf)
 {
        assert(conf != NULL);
-       assert(conf->conf_refcnt == 0);
 
        if (conf->conf_libopenarc != NULL)
                arc_close(conf->conf_libopenarc);
@glts glts changed the title arcf_config_free(): don't assert conf->refcnt == 0 arcf_config_free(): don't assert conf->conf_refcnt == 0 Jul 25, 2021
flowerysong pushed a commit to flowerysong/OpenARC that referenced this issue Feb 6, 2024
Sendmail does not guarantee that xxfi_close() is called before
smfi_main() returns when SIGHUP, SIGTERM or SIGINT is being handled,
so this reference counting is incorrect.

trusteddomainproject/OpenARC#147
abeverley added a commit to simplelists/OpenARC that referenced this issue Feb 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant