normalize slash (#33)

Author: hewigovens

client/client.go

@@ -134,10 +134,12 @@ func (r *Request) Execute(method string, url string, body io.Reader, result inte
 }
 
 func (r *Request) GetBase(path string) string {
+	baseUrl := strings.TrimRight(r.BaseUrl, "/")
 	if path == "" {
-		return r.BaseUrl
+		return baseUrl
 	}
-	return fmt.Sprintf("%s/%s", r.BaseUrl, path)
+	path = strings.TrimLeft(path, "/")
+	return fmt.Sprintf("%s/%s", baseUrl, path)
 }
 
 func GetBody(body interface{}) (buf io.ReadWriter, err error) {

client/client_test.go

@@ -0,0 +1,66 @@
+package client
+
+import (
+	"testing"
+)
+
+func TestRequest_GetBase(t *testing.T) {
+	type fields struct {
+		baseUrl string
+	}
+	tests := []struct {
+		name   string
+		fields fields
+		path   string
+		want   string
+	}{
+		{
+			name: "Test base url ends with /, path starts with /",
+			fields: fields{
+				baseUrl: "https://api.example.com/",
+			},
+			path: "/v1/account/0x32Be343B94f860124dC4fEe278FDCBD38C102D88",
+			want: "https://api.example.com/v1/account/0x32Be343B94f860124dC4fEe278FDCBD38C102D88",
+		},
+		{
+			name: "Test only base url ends with /",
+			fields: fields{
+				baseUrl: "https://api.example.com/",
+			},
+			path: "v1/account/0x32Be343B94f860124dC4fEe278FDCBD38C102D88",
+			want: "https://api.example.com/v1/account/0x32Be343B94f860124dC4fEe278FDCBD38C102D88",
+		},
+		{
+			name: "Test only path starts with /",
+			fields: fields{
+				baseUrl: "https://api.example.com",
+			},
+			path: "/v1/account/0x32Be343B94f860124dC4fEe278FDCBD38C102D88",
+			want: "https://api.example.com/v1/account/0x32Be343B94f860124dC4fEe278FDCBD38C102D88",
+		},
+		{
+			name: "Test none /",
+			fields: fields{
+				baseUrl: "https://api.example.com",
+			},
+			path: "v1/account/0x32Be343B94f860124dC4fEe278FDCBD38C102D88",
+			want: "https://api.example.com/v1/account/0x32Be343B94f860124dC4fEe278FDCBD38C102D88",
+		},
+		{
+			name: "Test empty path",
+			fields: fields{
+				baseUrl: "https://api.example.com/",
+			},
+			path: "",
+			want: "https://api.example.com",
+		},
+	}
+	for _, tt := range tests {
+		t.Run(tt.name, func(t *testing.T) {
+			r := InitClient(tt.fields.baseUrl)
+			if got := r.GetBase(tt.path); got != tt.want {
+				t.Errorf("Request.GetBase() = %v, want %v", got, tt.want)
+			}
+		})
+	}
+}