Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resources: add logo #114

Open
jusa3 opened this issue Aug 1, 2024 · 1 comment
Open

resources: add logo #114

jusa3 opened this issue Aug 1, 2024 · 1 comment

Comments

@jusa3
Copy link
Collaborator

jusa3 commented Aug 1, 2024

See BFO or CHEBI: https://www.ebi.ac.uk/ols4/ontologies
@VincentKneip
Copy link
Collaborator

Added a branch with a first draft for logos on ResourcesWidget (see pinned development branch).

  • Logos are only available in the v2-API of OLS, so I added a useLegacy-parameter to toggle the API version. Logos are then only shown if useLegacy == false
  • For now, logos have their own column in the EuiBasicTable. This is not optimal because some logos (e.g. from Human Disease Ontology) require a higher width to be properly displayed. One approach could be to additionally display the logos, if available, in the "Resource Name" column. However, this makes alphabetical sorting of this column more complicated, and a nice display of both items in one cell is not trivial in EuiBasicTable.

grafik

What is your opinion on the current status @jusa3?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

When branches are created from issues, their pull requests are automatically linked.

logos-resources ts4nfdi/terminology-service-suite
2 participants
@jusa3 @VincentKneip