Feat/ontology tab for metadatawidget #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good so far.
I would suggest that we use the abbreviation of the terminology for the tab header. I added two examples here.
|
…oInfoTab to terminologyInfoTab.
rombaum
approved these changes
Oct 15, 2024
|
🎉 This PR is included in version 2.11.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All implemented. However, I faced one issue that I could not find a workaround:
If you select a tab and then try to hide it via the boolean toggles in the storybook (when there is more than one tab), the EuiTabbedContent component raises an exception. As I looked, the reason is that the component uses react Ref to keep the currently selected tab. Since refs won't get updated during component re-rendered, it points to a non-existing tab (since you just hide it). I tried the official doc approach, but no luck: https://eui.elastic.co/#/navigation/tabs#controlled-tabbed-content
The point is, this most probably won't happen in the client app since the client app usually does not toggle hide and show and initiate the widget once. But creates issues in the storybook while playing around.