Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Login flow broke by a recent commit #593

Open
masterchiefag opened this issue Mar 16, 2017 · 1 comment
Open

Login flow broke by a recent commit #593

masterchiefag opened this issue Mar 16, 2017 · 1 comment

Comments

@masterchiefag
Copy link

This commit in PR #587 has broken the login flow.

The problematic change is:

(Earlier)

      self._me = me = self.get('me', fields="id,name,email,verified")

(Now)

      self._me = me = self.get('me')

In django_facebook/connect.py line 69:
email = facebook_data.get('email', False)
email comes out as False here and as a result the user lands to error page saying email field is required. Verified it by reverting this change.

@tschellenbach
Copy link
Owner

That analysis looks correct to me. I've just pushed a change on master.

About Maintenance & Django-Facebook

Django and Facebook are both rapidly changing at the moment. Meanwhile, I'm caught up in a startup and don't have much spare time. The library needs a good round of testing against the latest python, django and facebook graph API. Contributions are strongly appreciated. Seriously, give github a try, fork and get started :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants