Improve mapping for "with" hint (#133)

Author: tscpp

.changeset/loud-pets-wait.md

@@ -0,0 +1,5 @@
+---
+"@knuckles/fabricator": patch
+---
+
+Add "if" method to chunk.

.changeset/spotty-olives-do.md

@@ -0,0 +1,5 @@
+---
+"@knuckles/typescript": patch
+---
+
+Fix mapping with "with" hint.

packages/fabricator/src/chunk.ts

@@ -79,6 +79,18 @@ export class Chunk {
     return this;
   }
 
+  if(
+    condition: unknown,
+    positive: (chunk: this) => void,
+    negative?: (chunk: this) => void,
+  ) {
+    if (condition) {
+      positive(this);
+    } else {
+      negative?.(this);
+    }
+  }
+
   marker(id: string): this {
     this.#markers.add(new DynamicMarker(id, this.#text.length));
     return this;

packages/typescript/src/transpiler/transpiler.ts

@@ -281,13 +281,26 @@ class Renderer {
 
   #renderWithVirtualElement(node: ko.WithVirtualElement): Chunk {
     const childContext = new Chunk()
-      .append(`${ns}.hints.with(${ns}.type<typeof import(`)
-      .append(quote(node.import.module.value))
-      .append(")")
-      .append(
-        node.import.identifier.value === "*"
-          ? ""
-          : "[" + quote(node.import.identifier.value) + "]",
+      .append(`${ns}.hints.with(${ns}.type<`)
+      .while(
+        (chunk) =>
+          chunk
+            .append("typeof import(")
+            .append(node.import.module.text, { mirror: node.import.module })
+            .append(")")
+            .if(node.import.identifier.value !== "*", (chunk) =>
+              chunk.while(
+                (chunk) =>
+                  chunk
+                    .append('["')
+                    .append(quote(node.import.identifier.value).slice(1, -1), {
+                      mirror: node.import.identifier,
+                    })
+                    .append('"]'),
+                { blame: node.import.identifier },
+              ),
+            ),
+        { blame: node.import },
       )
       .append(">(), $context)");