Craft tsuru_certificate_issuer resource (#62)

* Craft tsuru_certificate_issuer resource

* refactor: simplify logic in resourceTsuruCertificateIssuerRead function

* Fix merge with new go-tsuruclient

* Fix tests of TestFluentDown

Author: wpjunior

go.mod

@@ -9,7 +9,7 @@ require (
 	github.com/labstack/echo/v4 v4.9.1
 	github.com/pkg/errors v0.9.1
 	github.com/stretchr/testify v1.9.0
-	github.com/tsuru/go-tsuruclient v0.0.0-20241029183502-e219a905d873
+	github.com/tsuru/go-tsuruclient v0.0.0-20241122210020-b97d66b89165
 	github.com/tsuru/tsuru-client v0.0.0-20240325204824-8c0dc602a5be
 	k8s.io/apimachinery v0.26.2
 )

go.sum

@@ -206,8 +206,8 @@ github.com/stretchr/testify v1.9.0 h1:HtqpIVDClZ4nwg75+f6Lvsy/wHu+3BoSGCbBAcpTsT
 github.com/stretchr/testify v1.9.0/go.mod h1:r2ic/lqez/lEtzL7wO/rwa5dbSLXVDPFyf8C91i36aY=
 github.com/tsuru/gnuflag v0.0.0-20151217162021-86b8c1b864aa h1:JlLQP1xa13a994p/Aau2e3K9xXYaHNoNvTDVIMHSUa4=
 github.com/tsuru/gnuflag v0.0.0-20151217162021-86b8c1b864aa/go.mod h1:UibOSvkMFKRe/eiwktAPAvQG8L+p8nYsECJvu3Dgw7I=
-github.com/tsuru/go-tsuruclient v0.0.0-20241029183502-e219a905d873 h1:Rs3urDCvqLpmGpUKOJNRiOCij/A+EcemdeOaGmGcs/E=
-github.com/tsuru/go-tsuruclient v0.0.0-20241029183502-e219a905d873/go.mod h1:qwh/KJ6ypa2GISRI79XFOHhnSjGOe1cZVPHF3nfrf18=
+github.com/tsuru/go-tsuruclient v0.0.0-20241122210020-b97d66b89165 h1:sDC3Z+/pfdviUdLIH2Tcxa2tVR6FSiTRIR0kWkK8iiQ=
+github.com/tsuru/go-tsuruclient v0.0.0-20241122210020-b97d66b89165/go.mod h1:qwh/KJ6ypa2GISRI79XFOHhnSjGOe1cZVPHF3nfrf18=
 github.com/tsuru/tablecli v0.0.0-20190131152944-7ded8a3383c6 h1:1XDdWFAjIbCSG1OjN9v9KdWhuM8UtYlFcfHe/Ldkchk=
 github.com/tsuru/tablecli v0.0.0-20190131152944-7ded8a3383c6/go.mod h1:ztYpOhW+u1k21FEqp7nZNgpWbr0dUKok5lgGCZi+1AQ=
 github.com/tsuru/tsuru v0.0.0-20240325190920-410c71393b77 h1:cuWFjNLaemdQZhojqJbb/rOXO97tlcPeLAHg/x+EQGk=

internal/provider/provider.go

@@ -70,6 +70,8 @@ func Provider() *schema.Provider {
 			"tsuru_app_deploy":    resourceTsuruApplicationDeploy(),
 			"tsuru_app":           resourceTsuruApplication(),
 
+			"tsuru_certificate_issuer": resourceTsuruCertificateIssuer(),
+
 			"tsuru_job":        resourceTsuruJob(),
 			"tsuru_job_env":    resourceTsuruJobEnvironment(),
 			"tsuru_job_deploy": resourceTsuruJobDeploy(),

internal/provider/resource_tsuru_app_autoscale.go

@@ -16,6 +16,7 @@ import (
 	"github.com/hashicorp/terraform-plugin-sdk/v2/helper/resource"
 	"github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema"
 	"github.com/pkg/errors"
+	"k8s.io/utils/ptr"
 
 	tsuru_client "github.com/tsuru/go-tsuruclient/pkg/tsuru"
 )
@@ -438,17 +439,17 @@ func scaleDownFromResourceData(meta interface{}) tsuru_client.AutoScaleSpecBehav
 		sd := iFace.(map[string]interface{})
 		if v, ok := sd["percentage"]; ok {
 			if val, ok := v.(int); ok {
-				scaleDown.PercentagePolicyValue = int32(val)
+				scaleDown.PercentagePolicyValue = ptr.To(int32(val))
 			}
 		}
 		if v, ok := sd["units"]; ok {
 			if val, ok := v.(int); ok {
-				scaleDown.UnitsPolicyValue = int32(val)
+				scaleDown.UnitsPolicyValue = ptr.To(int32(val))
 			}
 		}
 		if v, ok := sd["stabilization_window"]; ok {
 			if val, ok := v.(int); ok {
-				scaleDown.StabilizationWindow = int32(val)
+				scaleDown.StabilizationWindow = ptr.To(int32(val))
 			}
 		}
 	}

internal/provider/resource_tsuru_app_autoscale_flatten.go

@@ -57,15 +57,15 @@ func (fsd *flattenScaleDownBehavior) execute() interface{} {
 func (fsd *flattenScaleDownBehavior) withInputParameters(proposedList []map[string]interface{}) (value []map[string]interface{}) {
 	scaleDownCurrent := []map[string]interface{}{{}}
 	percentage, ok := fsd.findScaleDownInProposedList(proposedList, fsd.PERCENTAGE_LABEL)
-	if ok && percentage != 0 || fsd.ScaleDownRead.PercentagePolicyValue != int32(fsd.PERCENTAGE_VALUE) {
+	if ok && percentage != 0 || int32Value(fsd.ScaleDownRead.PercentagePolicyValue) != int32(fsd.PERCENTAGE_VALUE) {
 		scaleDownCurrent[0][fsd.PERCENTAGE_LABEL] = fsd.ScaleDownRead.PercentagePolicyValue
 	}
 	stabilizationWindow, ok := fsd.findScaleDownInProposedList(proposedList, fsd.STABILIZATION_WINDOW_LABEL)
-	if ok && stabilizationWindow != 0 || fsd.ScaleDownRead.StabilizationWindow != int32(fsd.STABILIZATION_WINDOW_VALUE) {
+	if ok && stabilizationWindow != 0 || int32Value(fsd.ScaleDownRead.StabilizationWindow) != int32(fsd.STABILIZATION_WINDOW_VALUE) {
 		scaleDownCurrent[0][fsd.STABILIZATION_WINDOW_LABEL] = fsd.ScaleDownRead.StabilizationWindow
 	}
 	units, ok := fsd.findScaleDownInProposedList(proposedList, fsd.UNITS_LABEL)
-	if ok && units != 0 || fsd.ScaleDownRead.UnitsPolicyValue != int32(fsd.UNITS_VALUE) {
+	if ok && units != 0 || int32Value(fsd.ScaleDownRead.UnitsPolicyValue) != int32(fsd.UNITS_VALUE) {
 		scaleDownCurrent[0][fsd.UNITS_LABEL] = fsd.ScaleDownRead.UnitsPolicyValue
 	}
 	return scaleDownCurrent
@@ -76,13 +76,13 @@ func (fsd *flattenScaleDownBehavior) noInputParameters(proposedList []map[string
 		return nil, false
 	}
 	scaleDownCurrent := []map[string]interface{}{{}}
-	if fsd.ScaleDownRead.PercentagePolicyValue != fsd.PERCENTAGE_VALUE {
+	if int32Value(fsd.ScaleDownRead.PercentagePolicyValue) != fsd.PERCENTAGE_VALUE {
 		scaleDownCurrent[0][fsd.PERCENTAGE_LABEL] = fsd.ScaleDownRead.PercentagePolicyValue
 	}
-	if fsd.ScaleDownRead.StabilizationWindow != fsd.STABILIZATION_WINDOW_VALUE {
+	if int32Value(fsd.ScaleDownRead.StabilizationWindow) != fsd.STABILIZATION_WINDOW_VALUE {
 		scaleDownCurrent[0][fsd.STABILIZATION_WINDOW_LABEL] = fsd.ScaleDownRead.StabilizationWindow
 	}
-	if fsd.ScaleDownRead.UnitsPolicyValue != fsd.UNITS_VALUE {
+	if int32Value(fsd.ScaleDownRead.UnitsPolicyValue) != fsd.UNITS_VALUE {
 		scaleDownCurrent[0][fsd.UNITS_LABEL] = fsd.ScaleDownRead.UnitsPolicyValue
 	}
 	if fsd.isScaleDownEmpty(scaleDownCurrent) {
@@ -91,6 +91,13 @@ func (fsd *flattenScaleDownBehavior) noInputParameters(proposedList []map[string
 	return scaleDownCurrent, true
 }
 
+func int32Value(ptr *int32) int32 {
+	if ptr != nil {
+		return *ptr
+	}
+	return 0
+}
+
 func (fsd *flattenScaleDownBehavior) findScaleDownInProposedList(proposedList []map[string]interface{}, key string) (value int, ok bool) {
 	for _, item := range proposedList {
 		if v, ok := item[key]; ok {

internal/provider/resource_tsuru_app_autoscale_scale_down_test.go

@@ -9,6 +9,7 @@ import (
 
 	"github.com/stretchr/testify/assert"
 	tsuru_client "github.com/tsuru/go-tsuruclient/pkg/tsuru"
+	"k8s.io/utils/ptr"
 )
 
 func TestFluentDown(t *testing.T) {
@@ -20,72 +21,72 @@ func TestFluentDown(t *testing.T) {
 	}{
 		{
 			scaleDownRead: tsuru_client.AutoScaleSpecBehaviorScaleDown{
-				UnitsPolicyValue:      3,
-				PercentagePolicyValue: 10,
-				StabilizationWindow:   300,
+				UnitsPolicyValue:      ptr.To(int32(3)),
+				PercentagePolicyValue: ptr.To(int32(10)),
+				StabilizationWindow:   ptr.To(int32(300)),
 			},
 			scaleDownInput: []interface{}{},
 			expected:       nil,
 		},
 
 		{
 			scaleDownRead: tsuru_client.AutoScaleSpecBehaviorScaleDown{
-				UnitsPolicyValue:      3,
-				PercentagePolicyValue: 10,
-				StabilizationWindow:   300,
+				UnitsPolicyValue:      ptr.To(int32(3)),
+				PercentagePolicyValue: ptr.To(int32(10)),
+				StabilizationWindow:   ptr.To(int32(300)),
 			},
 			scaleDownInput: []interface{}{
 				map[string]interface{}{"units": 3},
 			},
 			expected: []map[string]interface{}{{
-				"units": int32(3),
+				"units": ptr.To(int32(3)),
 			}},
 		},
 		{
 			scaleDownRead: tsuru_client.AutoScaleSpecBehaviorScaleDown{
-				UnitsPolicyValue:      3,
-				PercentagePolicyValue: 10,
-				StabilizationWindow:   300,
+				UnitsPolicyValue:      ptr.To(int32(3)),
+				PercentagePolicyValue: ptr.To(int32(10)),
+				StabilizationWindow:   ptr.To(int32(300)),
 			},
 			scaleDownInput: []interface{}{
 				map[string]interface{}{"units": 3},
 				map[string]interface{}{"stabilization_window": 300},
 				map[string]interface{}{"percentage": 10},
 			},
 			expected: []map[string]interface{}{{
-				"units":                int32(3),
-				"stabilization_window": int32(300),
-				"percentage":           int32(10),
+				"units":                ptr.To(int32(3)),
+				"stabilization_window": ptr.To(int32(300)),
+				"percentage":           ptr.To(int32(10)),
 			}},
 		},
 		{
 			scaleDownRead: tsuru_client.AutoScaleSpecBehaviorScaleDown{
-				UnitsPolicyValue:      21,
-				PercentagePolicyValue: 21,
-				StabilizationWindow:   21,
+				UnitsPolicyValue:      ptr.To(int32(21)),
+				PercentagePolicyValue: ptr.To(int32(21)),
+				StabilizationWindow:   ptr.To(int32(21)),
 			},
 			scaleDownInput: []interface{}{
 				map[string]interface{}{"units": 3},
 				map[string]interface{}{"stabilization_window": 300},
 				map[string]interface{}{"percentage": 10},
 			},
 			expected: []map[string]interface{}{{
-				"units":                int32(21),
-				"stabilization_window": int32(21),
-				"percentage":           int32(21),
+				"units":                ptr.To(int32(21)),
+				"stabilization_window": ptr.To(int32(21)),
+				"percentage":           ptr.To(int32(21)),
 			}},
 		},
 		{
 			scaleDownRead: tsuru_client.AutoScaleSpecBehaviorScaleDown{
-				UnitsPolicyValue:      21,
-				PercentagePolicyValue: 21,
-				StabilizationWindow:   21,
+				UnitsPolicyValue:      ptr.To(int32(21)),
+				PercentagePolicyValue: ptr.To(int32(21)),
+				StabilizationWindow:   ptr.To(int32(21)),
 			},
 			scaleDownInput: []interface{}{},
 			expected: []map[string]interface{}{{
-				"units":                int32(21),
-				"stabilization_window": int32(21),
-				"percentage":           int32(21),
+				"units":                ptr.To(int32(21)),
+				"stabilization_window": ptr.To(int32(21)),
+				"percentage":           ptr.To(int32(21)),
 			}},
 		},
 	}

internal/provider/resource_tsuru_app_autoscale_test.go

@@ -15,6 +15,7 @@ import (
 	echo "github.com/labstack/echo/v4"
 	"github.com/stretchr/testify/assert"
 	"github.com/tsuru/go-tsuruclient/pkg/tsuru"
+	"k8s.io/utils/ptr"
 )
 
 func TestAccResourceTsuruAppAutoscalePercentage(t *testing.T) {
@@ -753,9 +754,9 @@ func TestAccResourceTsuruAppAutoscaleScaleDown(t *testing.T) {
 				AverageCPU: "800m",
 				Behavior: tsuru.AutoScaleSpecBehavior{
 					ScaleDown: tsuru.AutoScaleSpecBehaviorScaleDown{
-						StabilizationWindow:   80,
-						UnitsPolicyValue:      5,
-						PercentagePolicyValue: 15,
+						StabilizationWindow:   ptr.To(int32(80)),
+						UnitsPolicyValue:      ptr.To(int32(5)),
+						PercentagePolicyValue: ptr.To(int32(15)),
 					},
 				},
 			}})

internal/provider/resource_tsuru_certificate_issuer.go

@@ -0,0 +1,161 @@
+// Copyright 2024 tsuru authors. All rights reserved.
+// Use of this source code is governed by a BSD-style
+// license that can be found in the LICENSE file.
+
+package provider
+
+import (
+	"context"
+	"sort"
+	"time"
+
+	"github.com/hashicorp/terraform-plugin-sdk/v2/diag"
+	"github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema"
+	"github.com/tsuru/go-tsuruclient/pkg/tsuru"
+)
+
+func resourceTsuruCertificateIssuer() *schema.Resource {
+	return &schema.Resource{
+		Description:   "Set a issuer to generate certificates to a tsuru application",
+		CreateContext: resourceTsuruCertificateIssuerSet,
+		ReadContext:   resourceTsuruCertificateIssuerRead,
+		DeleteContext: resourceTsuruCertificateIssuerUnset,
+		Timeouts: &schema.ResourceTimeout{
+			Create: schema.DefaultTimeout(60 * time.Minute),
+			Update: schema.DefaultTimeout(60 * time.Minute),
+			Delete: schema.DefaultTimeout(60 * time.Minute),
+		},
+		Importer: &schema.ResourceImporter{
+			StateContext: resourceTsuruApplicationImport,
+		},
+		Schema: map[string]*schema.Schema{
+			"app": {
+				Type:        schema.TypeString,
+				Description: "Application name",
+				Required:    true,
+				ForceNew:    true,
+			},
+
+			"cname": {
+				Type:        schema.TypeString,
+				Description: "Application CNAME",
+				Required:    true,
+				ForceNew:    true,
+			},
+
+			"issuer": {
+				Type:        schema.TypeString,
+				Description: "Certificate Issuer",
+				Required:    true,
+				ForceNew:    true,
+			},
+
+			"router": {
+				Type:        schema.TypeList,
+				Description: "Routers that are using the certificate",
+				Computed:    true,
+				Elem:        &schema.Schema{Type: schema.TypeString},
+			},
+
+			"certificate": {
+				Type:        schema.TypeList,
+				Description: "Certificate Generated by Issuer, filled after the certificate is ready",
+				Computed:    true,
+				Elem:        &schema.Schema{Type: schema.TypeString},
+			},
+
+			"ready": {
+				Type:        schema.TypeBool,
+				Description: "If the certificate is ready",
+				Computed:    true,
+			},
+		},
+	}
+}
+
+func resourceTsuruCertificateIssuerSet(ctx context.Context, d *schema.ResourceData, meta interface{}) diag.Diagnostics {
+	provider := meta.(*tsuruProvider)
+
+	app := d.Get("app").(string)
+	cname := d.Get("cname").(string)
+	issuer := d.Get("issuer").(string)
+
+	_, err := provider.TsuruClient.AppApi.AppSetCertIssuer(context.Background(), app, tsuru.CertIssuerSetData{
+		Cname:  cname,
+		Issuer: issuer,
+	})
+
+	if err != nil {
+		return diag.Errorf("unable to set certificate issuer: %v", err)
+	}
+
+	d.SetId(app + "::" + cname + "::" + issuer)
+
+	return resourceTsuruCertificateIssuerRead(ctx, d, meta)
+}
+
+func resourceTsuruCertificateIssuerUnset(ctx context.Context, d *schema.ResourceData, meta interface{}) diag.Diagnostics {
+	provider := meta.(*tsuruProvider)
+	parts, err := IDtoParts(d.Id(), 3)
+	if err != nil {
+		return diag.FromErr(err)
+	}
+	app := parts[0]
+	cname := parts[1]
+
+	_, err = provider.TsuruClient.AppApi.AppUnsetCertIssuer(context.Background(), app, cname)
+
+	if err != nil {
+		return diag.Errorf("unable to unset certificate issuer: %v", err)
+	}
+
+	return resourceTsuruCertificateIssuerRead(ctx, d, meta)
+}
+
+func resourceTsuruCertificateIssuerRead(ctx context.Context, d *schema.ResourceData, meta interface{}) diag.Diagnostics {
+	provider := meta.(*tsuruProvider)
+	parts, err := IDtoParts(d.Id(), 3)
+	if err != nil {
+		return diag.FromErr(err)
+	}
+	app := parts[0]
+	cname := parts[1]
+	issuer := parts[2]
+
+	certificates, _, err := provider.TsuruClient.AppApi.AppGetCertificates(context.Background(), app)
+	if err != nil {
+		return diag.FromErr(err)
+	}
+
+	usedRouters := []string{}
+	usedCertificates := []string{}
+
+	for routerName, router := range certificates.Routers {
+		cnameInRouter, ok := router.Cnames[cname]
+		if !ok {
+			continue
+		}
+
+		if cnameInRouter.Issuer != issuer {
+			continue
+		}
+		usedRouters = append(usedRouters, routerName)
+
+		if cnameInRouter.Certificate != "" {
+			usedCertificates = append(usedCertificates, cnameInRouter.Certificate)
+		}
+	}
+
+	sort.Strings(usedRouters)
+	sort.Strings(usedCertificates)
+
+	d.Set("app", app)
+	d.Set("cname", cname)
+	d.Set("issuer", issuer)
+
+	d.Set("router", usedRouters)
+	d.Set("certificate", usedCertificates)
+	d.Set("ready", len(usedCertificates) > 0)
+
+	return nil
+}