-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Building Run Results node #1
Comments
What we have currently output runSummary which we should break it down as much as possible. |
@mostaphaRoudsari If you like go for it, my suggestion is that make a call to GetRunSummaryResultsUri and also GetRunResultsUri's and check the json file and what it returns before parsing. |
@bhowes-tt & @mostaphaRoudsari I am getting "The remote server returned an error: (404) Not Found. " while sending request to GetRunResultUri. Ask GBS team whether the GBS can have new GetRunResultUri API for the result types per our discussion. This would be a good the signature for the Uri for getting results. GetRunResultsUri = @"/v1/run/results/{0}/{1}/{2}"; // 0 = runId, 1 = altRunId, 2=response format (gbxml || doe2 || inp || idf) *** *** @mostaphaRoudsari review the type of files u want the user is able to download from dynamo node. The node needs an input to identify the "type" of analysis result to download. |
Block out the signature Uri for get analysis results, new example added
Results Node Two: Get Energy Carbon Cost Summary: @mostaphaRoudsari do you prefer the breakdown info as an item of a list ? |
@eertugrul well done!
I think it looks better as it is now. The only change I would make is to return a list of strings instead of a single string so the user can select the one s/he wants based on list item. For GBSConnection.GetCarbonNeutralPotential I think the Units up there is confusing as the last one has a different unit. Maybe we should just add the unit at the end of all the outputs. My only concern is that it will be much nicer to have the numbers output as float/double and not string! I remember that we discussed adding the units to tooltips, but then we need to have dynamic tooltip for SI against IP. |
each result output should be a list - first item is the value, second item is the unit |
Not implemented to API yet by GBS !
Pull monthly data for a run, and output numeric results to user.
The text was updated successfully, but these errors were encountered: