ManyAddresses SmartPontentiometer

[gringow831]

I have been trying without much luck to add a new part for ManyAddresses::PBSmartPotentiometer. I can't see why it isn't working.

I'm guessing otherwise I could use the bank getSelection() to read which bank I am on and enable or disable more Smart Instances. (haven't tried this yet) Although thinking about that, if you have 16 pots and 4 different addresses it will become a very long script.

#pragma once


#include <AH/Containers/ArrayHelpers.hpp>
#include <Banks/BankAddresses.hpp>
#include <MIDI_Outputs/Bankable/Abstract/SmartMIDIFilteredAnalog.hpp>
#include <MIDI_Senders/PitchBendSender.hpp>

BEGIN_CS_NAMESPACE

namespace Bankable {
namespace ManyAddresses {

template <setting_t NumBanks>
class PBSmartPotentiometer
    : public Bankable::SmartMIDIFilteredAnalog<ManyAddresses<NumBanks>,
                                          PitchBendSender<10>> {
  public:

    PBSmartPotentiometer(const Bank<NumBanks> &bank, pin_t analogPin,
                    const Array<MIDIChannelCable, NumBanks> &addresses)
        : SmartMIDIFilteredAnalog<ManyAddresses<NumBanks>, PitchBendSender<10>>{
              {bank, AH::copyAs<MIDIAddress>(addresses)}, analogPin, {}} {}
};

} // namespace ManyAddresses
} // namespace Bankable

END_CS_NAMESPACE

AH_DIAGNOSTIC_POP()

[gringow831]

After an hour of trying to find the reason why it wouldn't work I came up with the solution. there was a NumBanks missing it seems.

namespace CS {

namespace Bankable {
namespace ManyAddresses {

template <setting_t NumBanks>
struct PBSmartPotentiometer : SmartMIDIFilteredAnalog<NumBanks, ManyAddresses<NumBanks>, PitchBendSender<10>> {
    PBSmartPotentiometer(const Bank<NumBanks> &bank, pin_t analogPin, const Array<MIDIChannelCable, NumBanks> &addresses)
        : SmartMIDIFilteredAnalog<NumBanks, ManyAddresses<NumBanks>, PitchBendSender<10>>{
              {bank, AH::copyAs<MIDIAddress>(addresses)}, analogPin, {}} {}
};

} // namespace ManyAddresses
} }

[gringow831]

in which part of the SmartMIDIFilteranalog function do I need to enter setPreviousValue(setting_t bank, analog_t value) in order to read the previous value from the DAW?
Sorry for all the questions

[tttapa]

What do you mean by reading the previous value from the DAW? SmartMIDIFilteredAnalog only sends data to the DAW, it doesn't read anything. You can of course read the data yourself in you main sketch, add a PBSmartPotentiometer::setPreviousValue function, and change it that way.

[gringow831]

the questions had to do with #566 but not entirely sure where to add that on the smartmidifilteranalog as you mentioned there

[tttapa]

You can add it here (untested):

namespace CS { namespace Bankable { namespace ManyAddresses {

template <setting_t NumBanks>
struct PBSmartPotentiometer : SmartMIDIFilteredAnalog<NumBanks, ManyAddresses<NumBanks>, PitchBendSender<10>> {
    PBSmartPotentiometer(const Bank<NumBanks> &bank, pin_t analogPin, const Array<MIDIChannelCable, NumBanks> &addresses)
        : SmartMIDIFilteredAnalog<NumBanks, ManyAddresses<NumBanks>, PitchBendSender<10>>{
              {bank, AH::copyAs<MIDIAddress>(addresses)}, analogPin, {}} {}

    // here ↓↓↓
    void setPreviousValue(setting_t bank, analog_t value) {
        previousValues[bank] = value;
    }
};

}}}