Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show toolbar on hover instead of on click on desktop devices #316

Open
StarScape opened this issue Mar 18, 2024 · 1 comment
Open

Show toolbar on hover instead of on click on desktop devices #316

StarScape opened this issue Mar 18, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@StarScape
Copy link

StarScape commented Mar 18, 2024

First of all, thanks for developing ッツ Reader. I had hacked together something similar on my own to be able to read ePub books with Yomichan, but ッツ is way more polished and a much better solution.

My proposed change: currently you have to click on the top of the screen to show/hide the toolbar. I think this behavior makes perfect sense on a touchscreen, but it feels a little unintuitive to me on a desktop browser (case in point, it took me a bit to figure out that's how you do it). I think it would be better if instead, the toolbar showed when you hovered over it, and then automatically disappear once the mouse had been moved off of it for a certain amount of time, say 1-2s. The current behavior could stay on mobile devices, if desired.

Thoughts? I'd be happy to implement this myself if the maintainers are willing to merge it.

@Renji-XD
Copy link
Collaborator

Hi,

i can't really comment if there was any other technical reason or just an ux decision. I don't really have hard feelings against it - not sure if that would be a problem in reality but upper part of text is quite close/slightly overlapping the header area.. that would be maybe annoying to some people which follow the lines with their cursor while reading...

so probably best to keep it behind an option with current behaviour as default and hidden/ignored on mobile (though that kind of defeats the purpose i guess :> )... of course need to be ensured that other functionality and things like menus/dialogs are not overlapped/impacted

feel free to submit a pr if you like

@Renji-XD Renji-XD added the enhancement New feature or request label Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants