Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add particle-dependent defaults for secondary calculators #364

Open
Jean1995 opened this issue Apr 18, 2023 · 0 comments
Open

Add particle-dependent defaults for secondary calculators #364

Jean1995 opened this issue Apr 18, 2023 · 0 comments
Labels

Comments

@Jean1995
Copy link
Member

Jean1995 commented Apr 18, 2023

The secondary calculators currently only provide a default parametrization per interaction type. However, the best defaults can be different for different particle types, see for example PR #347.

This needs a restructuration of the correct structure. Maybe one can adapt the current implementation:

SecondariesCalculator(
T const& interaction_types, ParticleDef const& p, Medium const& m)
{
for (auto& t : interaction_types)
addInteraction(
DefaultFactory<secondaries::Parametrization>::Create(t, p, m));
}

In a meaningful way, and add a method that is similar to the method we use for the cross sections?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant