Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

should there be a control to check ingress on security groups as well as #85

Closed
judell opened this issue Sep 12, 2023 · 3 comments · Fixed by #88
Closed

should there be a control to check ingress on security groups as well as #85

judell opened this issue Sep 12, 2023 · 3 comments · Fixed by #88
Assignees
@khushboo9024
Labels
enhancement New feature or request stale No recent activity has been detected on this issue/PR and it will be closed

Comments

@judell
Copy link

judell commented Sep 12, 2023

we have vpc_network_acl_allow_ssh_port_22_ingress but when scanning this example code (from https://spacelift.io/blog/iac-scanning) there was no complaint

resource "aws_security_group" "example_sg" {
  name        = "public_sg"
  description = "public security group"
  vpc_id      = aws_vpc.example_vpc.id
  ingress {
    from_port   = 22
    to_port     = 22
    protocol    = "tcp"
    cidr_blocks = ["0.0.0.0/0"]
  }

  egress {
    from_port   = 0
    to_port     = 0
    protocol    = "-1"
    cidr_blocks = ["0.0.0.0/0"]
  }
}
@judell judell added the enhancement New feature or request label Sep 12, 2023
@cbruno10
Copy link
Contributor

If helpful, when adapting these queries for VPC security group rules, the ingress rules in network ACLs can be found in ingress ->> 'cidr_block', while in security groups they're found in ingress ->> 'cidr_blocks'

@rajlearner17 rajlearner17 linked a pull request Sep 30, 2023 that will close this issue
Add controls to check ingress on security groups closes #85 #88
Merged
1 task
@github-actions GitHub Actions
Copy link

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 30 days.

@github-actions github-actions bot added the stale No recent activity has been detected on this issue/PR and it will be closed label Nov 14, 2023
@github-actions GitHub Actions
Copy link

This issue was closed because it has been stalled for 90 days with no activity.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Dec 15, 2023
@khushboo9024 khushboo9024 reopened this Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@khushboo9024 khushboo9024

Labels
enhancement New feature or request stale No recent activity has been detected on this issue/PR and it will be closed
Projects
None yet
Milestone
No milestone
3 participants
@judell @cbruno10 @khushboo9024