Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Short number functionality missing #54

Closed
asaf0000 opened this issue Feb 21, 2018 · 2 comments
Closed

Short number functionality missing #54

asaf0000 opened this issue Feb 21, 2018 · 2 comments

Comments

@asaf0000
Copy link

Hello,

The short number functionality is missing from the library.

In the original library or using this checker:
https://libphonenumber.appspot.com/phonenumberparser?number=911&country=US

For example, if I want to check if 911 is a valid number, then it says that is INVALID.
But if I see the short number results they say that it is a valid short number.

The library only has two function and is missing the others that are really useful:
isPossibleShortNumber()
isValidShortNumber()
isPossibleShortNumberForRegion()
isValidShortNumberForRegion()

Please help adding this functionality!
Thank you in advance

@twcclegg
Copy link
Owner

The whole of short number number parsing is indeed yet to be ported. That functionality along with the issues raised in #4, #41, and general geocoding are on my todo list.

@twcclegg
Copy link
Owner

Done 😀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants