-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to bzlmod #56
base: master
Are you sure you want to change the base?
Conversation
CI probably fails due to some older version of bazel which is used in the nixpkgs, but here I might need your input on which version of packages you want to use. |
It was used with skydoc, but we migrated to stardoc which does not produce the zip file anymore.
Thank you, @hofbi. That looks good! I'll update nixpkgs and push my changes in a moment... |
We are still using Bazel 7.1 and the lock file is not stable enough to be useful.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks again @hofbi!
BTW, we have to use Bazel 7.1.0 since that's what is available from nixpkgs right now. So I removed the lock file and added a .bazelversion to make the version explicit.
Sounds good, thanks. What do you guys think about using bazelisk to include bazel? This way you can easily control it from the version file and it is the recommended way for installing bazel. But definitely a follow up PR in case we wanna do that. Another task would also be to convert the tests to bzlmod. |
The tests include some Nix components and might depend on some of the patches made to Bazel in nixpkgs. |
Should we also migrate the tests to bzlmod in this PR? |
The tests use |
So are we good to merge? I can play arround with a follow up PR for the tests including the other deps as non module dependencies |
CI is still failing. :-(
That would be awesome! |
CI run on ubuntu is now green, but macos is failing with:
|
bazelbuild/bazel@3c47b47 seems to be relevant to the
|
I found envoyproxy/envoy-filter-example#121. From there I get the impression that XCode is required to be installed for some reason. |
I'm guessing |
How should we move on with this? Is there something I could/should try or do you have to clarify the next steps internally? |
Hello @hofbi. At this point I think some investigation is needed to explain why the OSX build is currently failing to find the |
I have no OSX hardware available so can only do debugging in CI, but will try my best |
Migrate the main project to bzlmod and rename all
BUILD
files toBUILD.bazel
Closes #53
Closes #54