Skip to content

Commit cfdb1f0

Browse files
committed
fixed order of field grabbing
Signed-off-by: Nick Papior <nickpapior@gmail.com>
1 parent afe1f42 commit cfdb1f0

File tree

2 files changed

+2
-6
lines changed

2 files changed

+2
-6
lines changed

src/towncrier/_settings/load.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -141,10 +141,10 @@ def load_config(directory: str) -> Config | None:
141141
if project_name := pyproject_config.get("project", {}).get("name", ""):
142142
# Fallback to the project name for the configuration name
143143
# and the configuration package entries.
144-
if not config.name:
145-
config.name = project_name
146144
if not config.package:
147145
config.package = project_name
146+
if not config.name:
147+
config.name = config.package
148148

149149
return config
150150

src/towncrier/test/test_settings.py

-4
Original file line numberDiff line numberDiff line change
@@ -257,16 +257,12 @@ def func(test):
257257
# name fallsback to package
258258
if "package" in tc_fields:
259259
package = "d"
260-
elif "package" in pp_fields:
261-
package = "b"
262260
else:
263261
package = "foo"
264262
self.assertEqual(config.package, package)
265263

266264
if "name" in tc_fields:
267265
self.assertEqual(config.name, "c")
268-
elif "name" in pp_fields:
269-
self.assertEqual(config.name, "a")
270266
else:
271267
# fall-back to package name
272268
self.assertEqual(config.name, package)

0 commit comments

Comments
 (0)